add REST Assured Support #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Awesome - thanks a lot for your PR. I will have a deeper look at it over the weekend. |
mduesterhoeft
suggested changes
Dec 8, 2018
...-api-spec/src/main/kotlin/com/epages/restdocs/apispec/RestAssuredRestDocumentationWrapper.kt
Outdated
Show resolved
Hide resolved
cnsgithub
force-pushed
the
rest-assured-support
branch
from
f28538f to
55f9c7b
Compare
RestAssured limitations removed
Remove the dependency to a specific spring-restdocs client from the restdocs-api-spec module and create two new modules: - restdocs-api-spec-mockmvc Contains the wrapper for spring-restdocs-mockmvnc - restdocs-api-spec-restassured Contains the wrapper for spring-restdocs-restassured
…for mockmvc support)
…ntext init failure
cnsgithub
force-pushed
the
rest-assured-support
branch
from
60993d7 to
6dd3ac8
Compare
mduesterhoeft
suggested changes
Dec 20, 2018
Contributor
mduesterhoeft
left a comment
mduesterhoeft
left a comment
There was a problem hiding this comment.
Thanks again for the contribution. This looks very good. I would just ask you to remove the sharing of test code between the new modules and go for code duplication instead.
Optionally if you find the time a simple sample for the restassured support would be great.
| @ExtendWith(SpringExtension::class) | ||
| @WebMvcTest | ||
| class MockMvcRestDocumentationWrapperIntegrationTest(@Autowired mockMvc: MockMvc) : ResourceSnippetIntegrationTest(mockMvc) { | ||
| class MockMvcRestDocumentationWrapperIntegrationTest(@Autowired private val mockMvc: MockMvc) : ResourceSnippetIntegrationTest() { |
Contributor
There was a problem hiding this comment.
I think I would rather not share code between the tests. Mainly because I think the gradle setup for this is a little exotic and also complex. I would rather go for the code duplication here.
Contributor
|
I will build a release tonight - I would like to add a few things to the readme first. |
Contributor
|
Released with 0.6.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a new
RestAssuredRestDocumentationWrapperthat can be used for REST Asssured documentation.