Add optional plugin config for tags descriptions to OpenAPI specs #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open API plugin will accept optional tagDescriptionsPropertiesFile attribute. The attribute expects a yaml file containing tag name and description Implements issue ePages-de#65
mduesterhoeft
suggested changes
Jan 9, 2019
Contributor
mduesterhoeft
left a comment
mduesterhoeft
left a comment
There was a problem hiding this comment.
Thanks also for this contribution. Looks really good to me! Could you please apply the naming change I suggested.
| servers = servers, | ||
| title = title, | ||
| description = apiDescription, | ||
| tags = tags, |
Contributor
There was a problem hiding this comment.
Can we call this tagDescriptions please (everywhere you now use tags)?
Contributor
Author
There was a problem hiding this comment.
No worries will make that change
mduesterhoeft
approved these changes
Jan 11, 2019
Contributor
|
@pgcarter I added the two new capabilities you added to the sample application as well. And the result using https://editor.swagger.io/ is really nice - thanks again.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open API plugin will accept optional tagDescriptionsPropertiesFile attribute.
The attribute expects a yaml file containing tag name and description
Implements issue #65