Skip to content

Conversation

@IkerLuengo
Copy link
Contributor

Signed-off-by: Iker Luengo ikerluengo@eprosima.com

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I have left this comment about the Fast DDS Gen repository. I am fine leaving this PR as it is.

README.md Outdated
or retrieve it with the `get_qos` methods of the entities, but it is not possible to modify the QoS values.
If you need to use non-default QoS, please use XML configuration files.
* Status listeners are not available. Even though python will not complain if you add a listener to an entity, the listener will not be triggered.
* Support in [*Fast DDS gen*](https://github.com/eProsima/Fast-DDS-Gen) is also limited to structs of simple types (no nested structs nor arrays or maps).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should include the new Fast DDS Gen option in the Fast DDS documentation.

I am not sure about linking the Fast DDS Gen repository, because it does not provide a README. Documentation can be found in the Fast DDS documentation only.

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IkerLuengo IkerLuengo merged commit f3537b1 into main Oct 28, 2021
@MiguelCompany MiguelCompany deleted the bugfix/readme branch October 28, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants