Skip to content

Full DDS API [14047] #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 91 commits into from
Mar 10, 2022
Merged

Full DDS API [14047] #12

merged 91 commits into from
Mar 10, 2022

Conversation

@richiware
Copy link
Member

@richiware richiware commented Mar 8, 2022 •
edited by EduPonz
Loading

This PR exposes the full Fast DDS DDS API to python.

@richiware richiware changed the title Full DDS API Full DDS API [14047] Mar 8, 2022
MiguelCompany
MiguelCompany requested changes Mar 9, 2022
View reviewed changes
jsan-rt
jsan-rt suggested changes Mar 9, 2022
View reviewed changes
jsan-rt
jsan-rt suggested changes Mar 9, 2022
View reviewed changes
jsan-rt
jsan-rt suggested changes Mar 9, 2022
View reviewed changes
MiguelCompany
MiguelCompany requested changes Mar 9, 2022
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WaitSets review

MiguelCompany
MiguelCompany requested changes Mar 9, 2022
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DataWriter

@EduPonz EduPonz marked this pull request as ready for review March 9, 2022 15:36
@EduPonz EduPonz added this to the v1.0.0 milestone Mar 9, 2022
richiware added 21 commits March 10, 2022 09:27
@richiware
Refs #13384. Test DomainParticipant::create_publisher
f887546 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Refs #13384. Add DomainParticipant::create_subsriber
0e45ad6 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Refs #13980. Add DomainParticipant::create_topic
71bd18c 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Refs #13980. Add DomainParticipant::set_listener
0a11a3a 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Refs #13980. Add DomainParticipant::find_topic
c4e9ecd 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Refs #13980. Add DomainParticipant::ignore_*
f278759 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Refs #13384. Add DomainParticipant::set_qos
558a9cd 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Refs #13384. Add DomainParticipant::enable
3489a34 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Refs #13384. Add DomainParticipant::delete_contained_entities
d546841 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Refs #13384. Add DomainParticipant::get_participant_names
0af520c 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Refs #13384. Add DomainParticipant::contains_entity
db805d2 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Refs #13384. Fix test_qos
93f839e 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Refs #13384. Initial publisher subscriber api
61414a0 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Refs #13384. Add Publisher::set_listener
d78e8a5 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Refs #13384. Add Publisher::create_datawriter
75d4ab2 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Refs #13384. Add Publisher::lookup_datawriter
bd4be94 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Refs #13384. Add Publisher::suspend_publications
d3b9616 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Refs #13384. Add Publisher::wait_for_acknowledgments
bcb36ec 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Refs #13384. Add Publisher::delete_contained_entities
e0718e7 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Refs #13384. Add Publisher::get_instance_handle
1393d48 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Refs #13384. Add Publisher::get_datawriters
ee98171 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
richiware and others added 14 commits March 10, 2022 09:27
@richiware
Refs #13384. Add DataReader::create_querycondition
b71baf0 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@EduPonz @richiware
Refs 13384: Simplify test_create_and_delete_datawriter
4c42034 
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
@EduPonz @richiware
Refs 13384: Test delete_publisher with contained entities
ff3d37f 
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
@EduPonz @richiware
Refs 13384: Simplify test_get_instance_handle
1f6e639 
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
@EduPonz @richiware
Refs 13384: Check publisher.has_datawriters with no datawriters
d379edf 
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
@EduPonz @richiware
Refs 13384: Simplify test_get_set_listener
59ceaa2 
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
@EduPonz @richiware
Refs 13384: Simplify test_create_and_delete_datareader
32aa92a 
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
@EduPonz @richiware
Refs 13384: Test delete_subscriber with contained entities
6f54223 
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
@EduPonz @richiware
Refs 13384: Check subscriber.has_datareaders with no datareaders
7a6e276 
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
@EduPonz @richiware
Refs #13384: Simplify test_get_instance_handle
d4089ef 
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
@EduPonz @richiware
Refs #13384: Simplify test_get_set_listener
8dddf22 
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
@EduPonz @richiware
Refs #13384: Commented check for delete_topic of a found topic
78da514 
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
@EduPonz @richiware
Refs #13384: datawriter test suggestions
f2c627f 
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
@richiware
Refs #13384. Fixes for windows
d11eb9d 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@MiguelCompany
Copy link
Member

@richiware This needs a rebase in order to get the changes to the CI job from #14

@richiware
Copy link
Member Author

@MiguelCompany rebase done

MiguelCompany
MiguelCompany requested changes Mar 10, 2022
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit

richiware and others added 3 commits March 10, 2022 12:26
@richiware
Refs #13384. Quick fix
2e33481 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@EduPonz
Refs #13384: Apply suggestions
678d50b 
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
@EduPonz
Refs #13384: Fix tests with statistics is enabled
63404ff 
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
MiguelCompany
MiguelCompany requested changes Mar 10, 2022
View reviewed changes
EduPonz added 2 commits March 10, 2022 13:08
@EduPonz
Refs #13384: Fix teke_next_sample test
397361d 
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
@EduPonz
Refs #13384: Apply suggestions
44b2307 
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
MiguelCompany
MiguelCompany previously approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz
Refs #13384: Bump version
2b96f2e 
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
@EduPonz EduPonz merged commit 34ab08a into main Mar 10, 2022
@EduPonz EduPonz deleted the feature/full-api branch March 10, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiguelCompany MiguelCompany MiguelCompany left review comments

+2 more reviewers

@jsan-rt jsan-rt jsan-rt requested changes

@EduPonz EduPonz EduPonz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@richiware @MiguelCompany @EduPonz @jsan-rt