Skip to content

[20869] Create DomainParticipantExtendedQos.i #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 24, 2024
Merged

[20869] Create DomainParticipantExtendedQos.i #146

merged 3 commits into from
Jun 24, 2024

Conversation

LuciaEchevarria99
Copy link
Contributor

@LuciaEchevarria99 LuciaEchevarria99 commented Jun 19, 2024 •
edited by elianalf
Loading

Description

Python binding corresponding to Fast-DDS PR: eProsima/Fast-DDS#4779

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Changes are API compatible.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • N/A: Check CI results: failing tests are unrelated with the changes.

@elianalf elianalf added this to the v2.0.0 milestone Jun 19, 2024
@LuciaEchevarria99 LuciaEchevarria99 changed the title Create DomainParticipantExtendedQos.i [20869] Create DomainParticipantExtendedQos.i Jun 19, 2024
elianalf and others added 3 commits June 24, 2024 08:57
@elianalf @LuciaEchevarria99
Refs #20869: Create DomainParticipantExtendedQos.i
f8b39df 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@LuciaEchevarria99
Refs #20869: Add create_participant test with ExtendedQos
4d150ca 
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
@LuciaEchevarria99
Extend DomainParticipantFactory.i API
ca13d54 
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
@elianalf elianalf added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Jun 24, 2024
@EduPonz EduPonz merged commit fb1dba6 into main Jun 24, 2024
@EduPonz EduPonz deleted the feature/extended_qos branch June 24, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@elianalf elianalf elianalf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@LuciaEchevarria99 @elianalf @EduPonz