Skip to content

Skip base branch in Fast CDR branch selection #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2025
Merged

Skip base branch in Fast CDR branch selection #229

merged 1 commit into from
Apr 4, 2025
+2 −0

Conversation

Carlosespicur
Copy link
Contributor

@Carlosespicur Carlosespicur commented Apr 4, 2025 •
edited by Mario-DL
Loading

Description

This PR fixes a CI error caused by selecting a Fast CDR branch with the same name as the Fast DDS Python base branch, instead of using the specified fallback_branch.

Contributor Checklist

  • NO Commit messages follow the project guidelines.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Changes are API compatible.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Carlosespicur
Skip base branch in Fast CDR branch selection
201a01a 
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
@Carlosespicur Carlosespicur requested a review from Mario-DL April 4, 2025 09:46
@github-actions github-actions bot added the ci-pending PR which CI is running label Apr 4, 2025
@Mario-DL
Copy link
Member

Mario-DL commented Apr 4, 2025

The cherry pick of this PR commit will be included in #224 #225 #226 #227 #228

@Mario-DL Mario-DL merged commit 7997ab2 into main Apr 4, 2025
6 checks passed
@Mario-DL Mario-DL deleted the hotfix/ignore-base-branch branch April 4, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

@Mario-DL Mario-DL Awaiting requested review from Mario-DL

Assignees

No one assigned

Labels

ci-pending PR which CI is running

Projects

None yet

Milestone

v2.2.1

Development

Successfully merging this pull request may close these issues.

3 participants

@Carlosespicur @Mario-DL @MiguelCompany