Skip to content

[13382] Several fixes #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jan 14, 2022
Merged

[13382] Several fixes #3

merged 21 commits into from
Jan 14, 2022

Conversation

@JLBuenoLopez
Copy link
Contributor

This PR includes several fixes:

  • Prefer fastdds namespace over fastrtps.
  • Move example from test folder to example one.
  • Fix listener callbacks.
  • Fix segmentation fault in participant destruction.
  • Add new interfaces required by Fast DDS 2.5.0 (ContentFilteredTopic).
  • Fix warnings (InstanceHandle, ParameterTypes, QosPolicies, md5).
  • Change module name to fastdds.
  • Update .repos file.
  • Update example types using Fast DDS Gen 2.1.0.

IkerLuengo and others added 18 commits January 7, 2022 12:38
@IkerLuengo @JLBuenoLopez
Prefer the FASTDDS namespace includes over FASTRTPS
e3e7c34 
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
@IkerLuengo @JLBuenoLopez
Refs 11914. Update test to use callbacks on the reader
d9ef56c 
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
@IkerLuengo @JLBuenoLopez
Refs 11914. Support callbacks defined in Python
7eb0657 
This requires:
 - Compiling the module using directors
 - Compiling the module using multithreading support on Python
 - Declaring which classes need directors (the callbacks)

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
@IkerLuengo @JLBuenoLopez
Refs 11914. Fix segmentation fault on Participant destruction
fe70187 
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
@IkerLuengo @JLBuenoLopez
Refs 11914. Create install target
d53bcbd 
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
@IkerLuengo @JLBuenoLopez
Refs 11914. Remove unnecessary links
e12de2c 
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
@IkerLuengo @JLBuenoLopez
Refs 11914. Convert old test into an example
ee55ec6 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@IkerLuengo @JLBuenoLopez
Refs 11914. Add a readme to the example
fe68595 
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
@IkerLuengo @JLBuenoLopez
Refs 11914. Move target module fastdds_wrapper to fastdds
c407f38 
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
@EduPonz @JLBuenoLopez
Refs 11914: Set Fast DDS branch to master
5ef0bf1 
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
@JLBuenoLopez
Refs #12678: add ContentFilteredTopic related headers
161c96c 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #12678: update .repos
8575169 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #12678: update types (generated with Fast DDS Gen 2.1.0)
ae66a46 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #12678: fix warnings introduced in Fast DDS 2.5.0 (new InstanceH…
326de90 
…andle operators, ContentFilter interfaces)

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #12678: fix undefined symbol issue
fd72635 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #13382: fix InstanceHandle class
bef868e 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #13382: fix warnings
9470c3e 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #13382: update README, limitations
8cb887d 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez JLBuenoLopez mentioned this pull request Jan 10, 2022
Closed
@JLBuenoLopez JLBuenoLopez added this to the v0.2.0 milestone Jan 10, 2022
@JLBuenoLopez JLBuenoLopez mentioned this pull request Jan 10, 2022
Merged
richiware
richiware requested changes Jan 12, 2022
View reviewed changes
@richiware
Refs #13382. Apply suggestions
3c9dad5 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
richiware
richiware requested changes Jan 12, 2022
View reviewed changes
@richiware
Refs #13382. Fix installation of examples's C++ library
0923bb5 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Refs #13382. Fix example's help message
7385de5 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
JLBuenoLopez
JLBuenoLopez commented Jan 13, 2022
View reviewed changes
Copy link
Contributor Author

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a small remark concerning changes done in an autogenerated file. Other changes made LGTM!

jsan-rt
jsan-rt approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@jsan-rt jsan-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richiware richiware merged commit 0dc2f3f into main Jan 14, 2022
@richiware richiware deleted the bugfix/fixes branch January 14, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richiware richiware richiware approved these changes

+2 more reviewers

@EduPonz EduPonz EduPonz left review comments

@jsan-rt jsan-rt jsan-rt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.2.0

Development

Successfully merging this pull request may close these issues.

6 participants

@JLBuenoLopez @richiware @EduPonz @jsan-rt @IkerLuengo