Add Qos API [13837] #7

richiware · 2022-02-11T09:32:43Z

Support for DDS QoS no Python bindings.

Need to be merge first eProsima/Fast-DDS#2492

jsan-rt

Partial review. Please check my comments regarding test_qos.py missing methods.

fastdds_python/CMakeLists.txt

fastdds_python/test/api/test_qos.py

jsan-rt

Just two small copy/paste comment errors. Also, DomainParticipantFactoryQos is not being tested at the moment. All of the other autoenablement qos are being tested so I think we should test that one too.

fastdds_python/test/api/test_qos.py

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Co-authored-by: jsantiago-eProsima <90755661+jsantiago-eProsima@users.noreply.github.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Co-authored-by: jsantiago-eProsima <90755661+jsantiago-eProsima@users.noreply.github.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

jsan-rt

These changes look good. I would like this test file to have a DomainParticipantFactoryQos test similar to this one at least, since i don't think that one is being tested.

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

jsan-rt

LGTM

* Refs #12820. Add base for testing Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #12820. Add DomainParticipantQos::name Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #12820. Add doxygen to DomainParticipantQos::name Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #12820. Add DomainParticipantQos::allocation Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #12820. Add DomainParticipantQos::entity_factory Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #12820. Add DomainParticipantQos::flow_controllers Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #12820. Add DomainParticipantQos::properties Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #12820. Add DomainParticipantQos::transports Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #12820. Add DomainParticipantQos::user_data Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #12820. Add DomainParticipantQos::wire_protocol Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #12820. Add PublisherQos Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #12820. Add SubscriberQos Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #12820. Add TopicQos Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #12820. Add DataWriterQos Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #12820. Add DataReaderQos Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #12820. Fix memory leak Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #12820. Little change Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #12820. Improve test_qos Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Add QoS related classes Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs 11914. Add missing classes and remove warnings Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs 11914. Several fixes and additions to classes Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs 11914. Testing types Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs 11914. PubSub implementation on Python Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs 11914. Types with const accessors Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #12678: update types (generated with Fast DDS Gen 2.1.0) Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #12820. Removed directory included in the rebase Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #13837. Fix flake8 warnings Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #13837. Apply suggestion about find_package Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * refs #13837. Apply suggestions about data_sharing Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Apply suggestion Co-authored-by: jsantiago-eProsima <90755661+jsantiago-eProsima@users.noreply.github.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #13837. Apply suggestion about max_blocking_time Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #13837. Apply suggestion about clean_up Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Apply suggestions from code review Co-authored-by: jsantiago-eProsima <90755661+jsantiago-eProsima@users.noreply.github.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #13837. Add DomainParticipantFactoryQos Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> Co-authored-by: Iker Luengo <ikerluengo@eprosima.com> Co-authored-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Co-authored-by: jsantiago-eProsima <90755661+jsantiago-eProsima@users.noreply.github.com>

richiware force-pushed the feature/qos-in-api branch from 64ab5ac to 3d1f132 Compare February 11, 2022 09:34

richiware changed the title ~~Add Qos API~~ Add Qos API [13837] Feb 11, 2022

jsan-rt suggested changes Feb 24, 2022

View reviewed changes

richiware force-pushed the feature/qos-in-api branch 2 times, most recently from 010552a to c9c2adb Compare February 24, 2022 18:57

jsan-rt suggested changes Feb 27, 2022

View reviewed changes

fastdds_python/test/api/test_qos.py Outdated Show resolved Hide resolved

fastdds_python/test/api/test_qos.py Outdated Show resolved Hide resolved

richiware and others added 24 commits February 28, 2022 10:49

Refs #12820. Add base for testing

2eb375e

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Refs #12820. Add DomainParticipantQos::name

8a16dbe

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Refs #12820. Add doxygen to DomainParticipantQos::name

92ddf37

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Refs #12820. Add DomainParticipantQos::allocation

6e17a93

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Refs #12820. Add DomainParticipantQos::entity_factory

51d129d

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Refs #12820. Add DomainParticipantQos::flow_controllers

a1e2c93

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Refs #12820. Add DomainParticipantQos::properties

7564098

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Refs #12820. Add DomainParticipantQos::transports

c0297a3

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Refs #12820. Add DomainParticipantQos::user_data

58e072e

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Refs #12820. Add DomainParticipantQos::wire_protocol

438e6f0

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Refs #12820. Add PublisherQos

427e659

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Refs #12820. Add SubscriberQos

7c58be8

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Refs #12820. Add TopicQos

2dec699

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Refs #12820. Add DataWriterQos

3026576

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Refs #12820. Add DataReaderQos

c85b2bb

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Refs #12820. Fix memory leak

2aad35d

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Refs #12820. Little change

a42b836

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Refs #12820. Improve test_qos

bb6801c

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Add QoS related classes

3a7ab14

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Refs 11914. Add missing classes and remove warnings

f4d6141

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Refs 11914. Several fixes and additions to classes

0e71112

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Refs 11914. Testing types

14800b1

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Refs 11914. PubSub implementation on Python

0c93cbc

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Refs 11914. Types with const accessors

9f8e22c

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

JLBuenoLopez and others added 9 commits February 28, 2022 10:50

Refs #12678: update types (generated with Fast DDS Gen 2.1.0)

abbc8e8

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Refs #12820. Removed directory included in the rebase

28cc529

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Refs #13837. Fix flake8 warnings

c312e99

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Refs #13837. Apply suggestion about find_package

b09b3f5

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

refs #13837. Apply suggestions about data_sharing

860b99f

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Apply suggestion

bdad135

Co-authored-by: jsantiago-eProsima <90755661+jsantiago-eProsima@users.noreply.github.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Refs #13837. Apply suggestion about max_blocking_time

2243b33

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Refs #13837. Apply suggestion about clean_up

5229eab

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Apply suggestions from code review

0f6e2fe

Co-authored-by: jsantiago-eProsima <90755661+jsantiago-eProsima@users.noreply.github.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

richiware force-pushed the feature/qos-in-api branch from d95eadc to 0f6e2fe Compare February 28, 2022 09:51

jsan-rt suggested changes Mar 7, 2022

View reviewed changes

Refs #13837. Add DomainParticipantFactoryQos

66af3d5

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

jsan-rt approved these changes Mar 7, 2022

View reviewed changes

richiware merged commit 46fb270 into main Mar 7, 2022

richiware deleted the feature/qos-in-api branch March 7, 2022 13:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add Qos API [13837] #7

Add Qos API [13837] #7

Uh oh!

richiware commented Feb 11, 2022 •

edited

Loading

Uh oh!

jsan-rt left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jsan-rt left a comment

Uh oh!

Uh oh!

Uh oh!

jsan-rt left a comment

Uh oh!

jsan-rt left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Add Qos API [13837] #7

Add Qos API [13837] #7

Uh oh!

Conversation

richiware commented Feb 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jsan-rt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jsan-rt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jsan-rt left a comment

Choose a reason for hiding this comment

Uh oh!

jsan-rt left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

richiware commented Feb 11, 2022 •

edited

Loading