Skip to content

corrections to validation status upload to minio#44

Merged
alexhambley merged 3 commits into
developfrom
removedatapath
Apr 25, 2025
Merged

corrections to validation status upload to minio#44
alexhambley merged 3 commits into
developfrom
removedatapath

Conversation

@douglowe
Copy link
Copy Markdown
Collaborator

Removing the data_path named variable from the ValidationSettings call because this variable was renamed rocrate_uri in commit crs4/rocrate-validator@f62a8ae

@douglowe douglowe requested a review from alexhambley April 21, 2025 18:35
@douglowe douglowe changed the title data_path renamed to rocrate_uri in rocrate-validator corrections to validation status upload to minio Apr 21, 2025
@douglowe
Copy link
Copy Markdown
Collaborator Author

I've also corrected the calculation of the length of the string object that is uploaded - previously we cut the string short because the length was taken of the dictionary, not the string.

@douglowe
Copy link
Copy Markdown
Collaborator Author

And I've (finally) realised that the validation_status object passed to this function is a string.

The original string is in pretty JSON format (with line endings and indents). So I've retained the json.dumps function, but within this I use a json_loads function to turn this pretty string into a dictionary, which is then turned back into a less pretty, but infinitely more useful, string.

@alexhambley alexhambley merged commit b1fbdd5 into develop Apr 25, 2025
@douglowe douglowe deleted the removedatapath branch May 16, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants