build container and deploy to ghpackages on release#49
Merged
Conversation
OliverWoolland
previously approved these changes
May 12, 2025
OliverWoolland
approved these changes
May 12, 2025
Contributor
|
Looks good - I'll make an issue for the future to consider MinIO security + switching to k8s implementation of secrets |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This workflow will build the container only when a tagged release is made.
I've also modified the docker compose script to use these built containers, while retaining the original docker compose file as a development script. The README has been amended to reflect this.
Currently the docker compose is set to use the 'latest' tagged release - but we can change this when merging our release candidate into main.