Skip to content

expose student identifier field #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kochalex merged 2 commits into from
Jan 23, 2026
Merged

expose student identifier field #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
faa5239
expose student identifier field
kochalex Jan 22, 2026
2047c98
Merge branch 'master' into student-identifier
kochalex Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/types/student.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ class Student < Base
:provider,
:email,
:grades,
:school_id
:school_id,
:identifier

def initialize(attributes = {}, client: nil)
@uid = attributes['sourcedId']
Expand All @@ -23,6 +24,7 @@ def initialize(attributes = {}, client: nil)
@provider = 'oneroster'
@grades = attributes['grades']
@school_id = school_id_from(attributes)
@identifier = attributes['identifier']
end

def username(client = nil)
Expand All @@ -47,7 +49,8 @@ def to_h
provider: @provider,
email: @email,
grades: @grades,
school_id: @school_id
school_id: @school_id,
identifier: @identifier
}
end

Expand Down
3 changes: 2 additions & 1 deletion spec/client_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,7 +699,8 @@
provider: 'oneroster',
email: student_1['email'],
grades: student_1['grades'],
school_id: nil
school_id: nil,
identifier: student_1['identifier']
)
end
end
Expand Down
3 changes: 2 additions & 1 deletion spec/support/api_responses.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,8 @@
'username' => '',
'email' => '',
'status' => 'active',
'junk' => 'data'
'junk' => 'data',
'identifier' => 'student_identifier_1'
}
end

Expand Down