Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -2,37 +2,47 @@ | |||
| "cells": [ | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes, great suggestion!
| @@ -2,37 +2,47 @@ | |||
| "cells": [ | |||
There was a problem hiding this comment.
Instead of hardcoding lat/lon. Can we use grdc_latitude and grdc_longitude vars instead?
Reply via ReviewNB
| @@ -2,37 +2,47 @@ | |||
| "cells": [ | |||
There was a problem hiding this comment.
Hard to see that lines 1,4,5 are the concept due to lots of plotting code. Can the cell be split on line 6 and the comment be promoted to Markdown?
Reply via ReviewNB
| @@ -2,37 +2,47 @@ | |||
| "cells": [ | |||
There was a problem hiding this comment.
Instead of hardcoding lat/lon. Can we use grdc_latitude and grdc_longitude vars instead?
Reply via ReviewNB
sverhoeven
left a comment
sverhoeven
left a comment
There was a problem hiding this comment.
Was able to run the notebook successfully.
Made some suggestions in reviewnb.
Might also be nice to use a lat/lon bounding box instead of index range ([31:41, 18:28]).
Spawned off #182
|
Kudos, SonarCloud Quality Gate passed!
|
|
@sverhoeven all suggestions applied except for |
sverhoeven
left a comment
sverhoeven
left a comment
There was a problem hiding this comment.
Looks good.
I like the description for running the experiment, much clearer.
Yep lets merge this PR and work on #185 later as its less critical. |
2 participants
Using the updated API. Didn't change much about the notebook itself since it was already quite nice.
(branched off a previous PR so hence the many commits).
https://ewatercycle--180.org.readthedocs.build/en/180/examples/Irrigation.html