Call buffer.readIntLE with arguments
#17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fixed this by letting the protobufjs library handle decoding of primitive values. Maybe krpc-node could profit from this as well? |
Owner
|
My apologies, I got married and was on honeymoon so have been off the radar for a bit! |
This was referenced Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node's buffer.readIntLE is documented as having two required arguments, offset and bytelength. This file calls the method several times with no arguments. This was causing issues for me on mac, node v12.4.0. I modified these two calls to pass those arguments, which I found through trial and error. I don't understand what they do. That was enough to get my specific program running. This PR is not a fix - it's an explanation of what I think might be causing issue #16. Hopefully it's useful for you or someone in finding and fixing the issue.
Thanks for an awesome library, I have been having great fun crashing lots of spacecraft.