You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
related to #8264
i am not sure how triage thing works but the issue is currently marked as not-planned, so i am leaving this discussion thread here instead opening a PR with fix
Pi emits OSC 133 sequences around assistant messages. Kitty interprets these as shell integration command markers, so with notify_on_cmd_finish unfocused in kitty config, it triggers a command-finish notification after each assistant response during an agent run.
Originally #1805 is where OSC markers were added but only to user messages, later the commit 3ba0d85 added same to assistant messages as well. That seems unnecessary to me, even from navigation perspective.
I tested removing the OSC 133 markers from AssistantMessageComponent, and that fixes the repeated notifications for me. The change is small and the related tests were updated accordingly: f1fdd83
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
related to #8264
i am not sure how triage thing works but the issue is currently marked as not-planned, so i am leaving this discussion thread here instead opening a PR with fix
Pi emits OSC 133 sequences around assistant messages. Kitty interprets these as shell integration command markers, so with
notify_on_cmd_finish unfocusedin kitty config, it triggers a command-finish notification after each assistant response during an agent run.Originally #1805 is where OSC markers were added but only to user messages, later the commit 3ba0d85 added same to assistant messages as well. That seems unnecessary to me, even from navigation perspective.
I tested removing the OSC 133 markers from
AssistantMessageComponent, and that fixes the repeated notifications for me. The change is small and the related tests were updated accordingly: f1fdd83All reactions