Disable IRQs on RP2040 during HW division #3250
Open
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The divider is a shared HW resource, and when an IRQ comes in (i.e. when a packet is processed by LWIP and the user's callbacks) its state can be corrupted silently and randomly.
Change the Pico-SDK defaults to disable IRQs during division operations, avoiding the issue by disallowing the LWIP callback to happen until after division is completed.
Fixes #3212