add try block to return useful error message for failed download#263
Merged
betolink merged 1 commit intoearthaccess-dev:mainfrom Jul 22, 2023
Merged
Conversation
|
I will automatically update this comment whenever this PR is modified |
betolink
approved these changes
Jul 22, 2023
Contributor
betolink
left a comment
betolink
left a comment
There was a problem hiding this comment.
Thanks Andy! maybe down the road we should handle the error in the store class so when that happens is not the API that sounds the alarm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR address #262.
Following the api workflow in the readme, if
earthaccess.login()is not executed before download, download fails with an ambiguousAttributeError. To fix this, I added atry-exceptblock todownloadinapi.py, so that the user is advised to runearthdata.login()before attempting to download andNoneis returned.