remove accidental debug printf#34
Merged
Merged
Conversation
A context canceled error will occur once the runc container has exited, there is not need to log these errors. Additionally, remove a printf that was accidentally committed.
alexcb
force-pushed
the
acb/remove-printf
branch
from
4bfa44f to
b61b1c9
Compare
vladaionescu
approved these changes
Nov 18, 2023
| if err != nil { | ||
| if errors.Is(err, context.Canceled) { | ||
| return | ||
| } |
Member
There was a problem hiding this comment.
Just double-checking that this is also an intended change as part of this PR
Contributor
Author
There was a problem hiding this comment.
yes -- it is, it's unfortunate github doesn't update the description when a git rebase occurs, I changed to the commit message to this:
dont log context canceled errors
A context canceled error will occur once the runc container has exited,
there is not need to log these errors.
Additionally, remove a printf that was accidentally committed.
but forgot to copy/paste it under the description here.
^^ github product owners take note 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.