Fix Python 3.6 migration#2
Merged
westover merged 8 commits intoearthmine:developfrom Sep 4, 2017
Merged
Conversation
This make it so that the files in the vent are copied from the source machine when creating the jar files. If this is not present, recent versions of virtualenv will symlink and cause bad links in the jar files. Bad links mean that the files will not exist when the jar is actually run. This fix ensures that all required files in the venv are copied over so you do not actually have to have python installed on your pyleus cluster. This is the root cause of the `ImportError: No module named 'encodings'` problem in YelpArchive#50
…into fix-py36 # Conflicts: # tests/cli/virtualenv_proxy_test.py
…end, JAVA component, does not expect unicode).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly string encoding issues. Also integrated the stdlib packaging fix from justquick/pyleus.