Skip to content

delete Unnecessary Code#28

Merged
kwonkwonn merged 1 commit intoDevfrom
deleteUnnecessaryCode
Mar 3, 2026
Merged

delete Unnecessary Code#28
kwonkwonn merged 1 commit intoDevfrom
deleteUnnecessaryCode

Conversation

@wind5052
Copy link
Contributor

@wind5052 wind5052 commented Mar 1, 2026

현재 사용중이지 않은 코드를 삭제하였습니다. 확인 바랍니다

@coderabbitai
Copy link

coderabbitai bot commented Mar 1, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch deleteUnnecessaryCode

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kwonkwonn
Copy link
Contributor

GoodGGori

Copy link
Contributor

@kwonkwonn kwonkwonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UpdateInstance 가 구 스키마 용인지만 확인하고 지우면 될 거 같아요.

}

// 현재 미사용중
// 이건 미사용중이면 안되지않나? 인스턴스정보 DB에 업데이트 하는거같은데
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_, err = tx.ExecContext(ctx, "INSERT INTO inst_info (uuid, inst_ip, guac_pass, inst_mem, inst_vcpu, inst_disk) VALUES (?, ?, ?, ?, ?, ?)",

<--- 이 친구랑 로직이 어느정도 겹치는 것 같은데 업데이트 전 db 스키마에서 쓰던 것인지, 확인하면 될 것 같아요

// 현재 미사용 중
// 코어 vcpu 갯수 가져오는 함수
// 코어에 문의 해봐야함 옛날에 구현 안됬다고 해서 컨트롤에서 9999로 하드코딩 했던거 같음
func (c *CoreClient) GetCoreMachineCpuInfo(context context.Context) (*model.CoreMachineCpuInfoResponse, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

서비스는 구현이 되어있을텐데, 현재 개발환경이 없어서 바로 가져다 쓸 수 있을지는 검증해봐야 됩니당.
그떄 알려드릴게요

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#27 (comment)
<-- 여기 구현되어 있다고 하네요. 참고바랍니다

@kwonkwonn kwonkwonn merged commit a4f7fd5 into Dev Mar 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants