Fix Windows OpenMP wheel build#171
Merged
Merged
Conversation
Collaborator
Author
|
CI follow-up from this fix:
So this PR addresses the Windows OpenMP wheel/build hard failure specifically; the remaining red checks are pre-existing CI baseline/workflow issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#pragma omp atomic updatewith the portable OpenMP atomic formparallel forloops in modularity helpersmerge-multipleinput from the cibuildwheel stepVerification
python3 -m pip wheel . --no-deps -w /tmp/easygraph-wheel-openmp-fixgit diff --checkNotes
The original failing workflow was
Build,download and publish wheelsrun 27082170598. The hard failure was in the Windowscp38-win32wheel build with MSVC OpenMP errors C7660 and C3016. I did not manually rerun the publish workflow because it includes a PyPI publish job after wheel builds complete.