Skip to content

Fix Windows OpenMP wheel build#171

Merged
eggpig merged 1 commit into
pybind11from
fix/windows-openmp-wheel
Jun 7, 2026
Merged

Fix Windows OpenMP wheel build#171
eggpig merged 1 commit into
pybind11from
fix/windows-openmp-wheel

Conversation

@eggpig
Copy link
Copy Markdown
Collaborator

@eggpig eggpig commented Jun 7, 2026

Summary

  • replace MSVC-incompatible #pragma omp atomic update with the portable OpenMP atomic form
  • use signed loop indices for OpenMP parallel for loops in modularity helpers
  • remove the unsupported merge-multiple input from the cibuildwheel step

Verification

  • python3 -m pip wheel . --no-deps -w /tmp/easygraph-wheel-openmp-fix
  • git diff --check

Notes

The original failing workflow was Build,download and publish wheels run 27082170598. The hard failure was in the Windows cp38-win32 wheel build with MSVC OpenMP errors C7660 and C3016. I did not manually rerun the publish workflow because it includes a PyPI publish job after wheel builds complete.

@eggpig
Copy link
Copy Markdown
Collaborator Author

eggpig commented Jun 7, 2026

CI follow-up from this fix:

  • The previous Windows MSVC OpenMP hard error is fixed in PR code review: both build (windows-latest, 3.9) and build (windows-latest, 3.12) passed the Build and install step.
  • Those jobs still fail later at the existing Test step because .github/workflows/pr_code_check.yaml runs python tests/test.py, but tests/test.py does not exist in this repository.
  • pre-commit is also still failing on existing all-files formatting changes outside this PR's C++/wheel scope.
  • The pytest workflow still fails on the current baseline tests noted separately.

So this PR addresses the Windows OpenMP wheel/build hard failure specifically; the remaining red checks are pre-existing CI baseline/workflow issues.

@eggpig eggpig merged commit 2b6bd72 into pybind11 Jun 7, 2026
0 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant