Skip to content

Conversation

@boegel
Copy link
Member

@boegel boegel commented Oct 26, 2022

This was a pretty big effort to port, so it deserves a careful review by a 2nd pair of eyes...

@boegel boegel added the porting-to-mkdocs Porting effort from Sphinx/.rst to MkDocs/.md label Oct 26, 2022
@boegel boegel marked this pull request as ready for review October 28, 2022 19:33
@orbsmiv
Copy link
Collaborator

orbsmiv commented Nov 3, 2022

@boegel I'll update this PR with the changes we've made to the internal linking system so that it's consistent with the other current PRs. I'll pop it on "draft" for now but please feel free to overrule if you want to get it merged and mop the links up later!

@orbsmiv orbsmiv marked this pull request as draft November 3, 2022 11:35
@orbsmiv orbsmiv marked this pull request as ready for review November 4, 2022 23:09
@orbsmiv orbsmiv mentioned this pull request Nov 4, 2022
@orbsmiv orbsmiv marked this pull request as draft November 5, 2022 09:06
@boegel
Copy link
Member Author

boegel commented Nov 5, 2022

@boegel I'll update this PR with the changes we've made to the internal linking system so that it's consistent with the other current PRs. I'll pop it on "draft" for now but please feel free to overrule if you want to get it merged and mop the links up later!

Makes sense to me, thanks for the effort!

@orbsmiv orbsmiv marked this pull request as ready for review November 5, 2022 23:37
@orbsmiv
Copy link
Collaborator

orbsmiv commented Nov 5, 2022

@branfosj I've looked through the whole page and also checked each link. The autorefs links, (e.g. mkdocs_autorefs.plugin: using-easybuild.md: Could not find cross-reference target '[basic_usage_help]') refer to headers that will be in the auto-generated version_specific files. I've created an issue (c.f. #24) to log these as and when they crop-up, although I think that we should add a placeholder file to hold all of the link-names whilst the script to generated the actual content is being written.

@orbsmiv orbsmiv requested a review from branfosj November 6, 2022 00:16
@branfosj branfosj merged commit 07cfa65 into easybuilders:main Nov 6, 2022
@boegel boegel deleted the using-easybuild branch November 7, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

porting-to-mkdocs Porting effort from Sphinx/.rst to MkDocs/.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants