Skip to content

Conversation

@boegel
Copy link
Member

@boegel boegel commented Jul 5, 2021

No description provided.

Flamefire and others added 30 commits May 28, 2021 11:12
Instead of assuming that everything that doesn't look like a patch is an
EC, assume *.patch files are patches and error out with a clear message
why it was not detected as such.
Avoids confusing errors such as:
ERROR: Failed to process easyconfig foo.patch: Parsing easyconfig file failed: invalid syntax (<string>, line 1)
sync with main + bump version to 4.4.1dev
avoid overwritting pr_nr in post_pr_test_report for reports with --in…
…writing variables outside of list comprehension when using Python 2
This hook will be called anytime a module is written, so even for the
fake modules used for sanity checks etc.
It gets passed the easyblock as the first argument and the filename and
content to be written as the next 2 and may return a new text to be used
for the module file. If nothing or None is returned the original text
will be used.
can't be serialized. For instance `os`, if it is imported in a eb file
… overwriting variables outside of list comprehensions when using Python 2
…e_letter_variables

use even more single-letter variables in list comprehensions to avoid overwriting variables outside of list comprehensions when using Python 2
Shows e.g.:
== fetching files...
== creating build dir, resetting environment...
== ... (took 2 secs)
== unpacking...
== ... (took 15 secs)
== patching...
== ... (took 7 secs)
enhance test for post_pr_test_report to cover combination of --from-pr and --include-easyblocks-from-pr
Users can now use --ignore-test-failure instead of --skip-test-step
which will run the tests but does not abort on error and just prints it instead.

Using both options doesn't make sense and is hence disallowed and a
warning is show to make users move to ignoring failures instead of
skipping the test completely.
…b' in the test name so that they can be easily filtered
parse C standard flags in CFLAGS for fujitsu compiler
…_name

don't override COMPILER_MODULE_NAME, inherited from Ffmpi, in Fujitsu toolchain definition
SebastianAchilles and others added 18 commits June 25, 2021 16:06
Add option to ignore failing test step
warn about generic milestone in --review-pr and --merge-pr
Eerror out when passing a list to run_cmd* to avoid running wrong command unintended, unless shell=True is used
Consider sources provided as dict in EasyBlock.check_checksums_for
don't make changes to software installation directory when using --sanity-check-only
honor specified easyblock for extensions
prepare release notes for EasyBuild v4.4.1 + bump version to 4.4.1
@boegel boegel added the update label Jul 5, 2021
@boegel boegel added this to the next release (4.4.1) milestone Jul 5, 2021
@boegel boegel requested a review from migueldiascosta July 5, 2021 10:04
@boegel
Copy link
Member Author

boegel commented Jul 5, 2021

failing test is fixed with #3765

branfosj and others added 2 commits July 5, 2021 13:40
make sure that test for --list-easyblocks is run first, before other tests that pick up additional easyblocks
@easybuilders easybuilders deleted a comment from boegelbot Jul 5, 2021
Copy link
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Member

Going in, thanks @boegel!

@migueldiascosta migueldiascosta merged commit 184219a into main Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.