-
Notifications
You must be signed in to change notification settings - Fork 217
release EasyBuild v4.4.1 #3764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
release EasyBuild v4.4.1 #3764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of assuming that everything that doesn't look like a patch is an EC, assume *.patch files are patches and error out with a clear message why it was not detected as such. Avoids confusing errors such as: ERROR: Failed to process easyconfig foo.patch: Parsing easyconfig file failed: invalid syntax (<string>, line 1)
sync with main + bump version to 4.4.1dev
…clude-easyblocks-from-pr
avoid overwritting pr_nr in post_pr_test_report for reports with --in…
…r and --include-easyblocks-from-pr
…writing variables outside of list comprehension when using Python 2
This hook will be called anytime a module is written, so even for the fake modules used for sanity checks etc. It gets passed the easyblock as the first argument and the filename and content to be written as the next 2 and may return a new text to be used for the module file. If nothing or None is returned the original text will be used.
can't be serialized. For instance `os`, if it is imported in a eb file
…st name so that they can be easily filtered
… overwriting variables outside of list comprehensions when using Python 2
…e_letter_variables use even more single-letter variables in list comprehensions to avoid overwriting variables outside of list comprehensions when using Python 2
Shows e.g.: == fetching files... == creating build dir, resetting environment... == ... (took 2 secs) == unpacking... == ... (took 15 secs) == patching... == ... (took 7 secs)
enhance test for post_pr_test_report to cover combination of --from-pr and --include-easyblocks-from-pr
Users can now use --ignore-test-failure instead of --skip-test-step which will run the tests but does not abort on error and just prints it instead. Using both options doesn't make sense and is hence disallowed and a warning is show to make users move to ignoring failures instead of skipping the test completely.
…b' in the test name so that they can be easily filtered
parse C standard flags in CFLAGS for fujitsu compiler
…_name don't override COMPILER_MODULE_NAME, inherited from Ffmpi, in Fujitsu toolchain definition
add toolchain nvompic
Add option to ignore failing test step
warn about generic milestone in --review-pr and --merge-pr
Eerror out when passing a list to run_cmd* to avoid running wrong command unintended, unless shell=True is used
…nity-check-only (fixes #3757)
Consider sources provided as dict in EasyBlock.check_checksums_for
…sanity-check-only
don't make changes to software installation directory when using --sanity-check-only
…(should derive from Extension class)
honor specified easyblock for extensions
prepare release notes for EasyBuild v4.4.1 + bump version to 4.4.1
…tests that pick up additional easyblocks
Member
Author
|
failing test is fixed with |
make sure that test for --list-easyblocks is run first, before other tests that pick up additional easyblocks
migueldiascosta
approved these changes
Jul 6, 2021
Member
migueldiascosta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Member
|
Going in, thanks @boegel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.