fix sub-toolchains of NVHPC and NVHPCToolchain and load each one where appropriate#5103
Merged
lexming merged 7 commits intoeasybuilders:developfrom Feb 4, 2026
Merged
Conversation
By checking tcdeps for GCCcore instead of nvidia-compilers, we can use __new__() to replace NVHPC by NVHPCToolchain for legacy NVHPC compiler-only toolchains. This toolchain then also needs the correct module name overridden from nvidia-compilers. Fixes easybuilders#5102
Contributor
Author
|
needs a test case, so drafting for now |
lexming
reviewed
Feb 4, 2026
Contributor
lexming
left a comment
lexming
left a comment
There was a problem hiding this comment.
Thanks for the fix! LGTM
Just a few minor suggestions to improve the comments
lexming
changed the title
Co-authored-by: Alex Domingo <alex.domingo.toro@vub.be>
Co-authored-by: Alex Domingo <alex.domingo.toro@vub.be>
Co-authored-by: Alex Domingo <alex.domingo.toro@vub.be>
Contributor
|
Merging, thanks @bartoldeman ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By checking tcdeps for GCCcore instead of nvidia-compilers, we can use new() to replace NVHPC by NVHPCToolchain for legacy NVHPC compiler-only toolchains. This toolchain then also needs the correct module name overridden from nvidia-compilers.
Fixes #5102