config breaking check#226
Merged
hound672 merged 2 commits intoMay 17, 2026
Merged
Conversation
Yakwilik
approved these changes
May 17, 2026
There was a problem hiding this comment.
Pull request overview
This PR adds configuration plumbing for a new breaking-check option intended to enable FILES_CHECK.
Changes:
- Adds
breaking.useto the config model and example config. - Introduces
FILES_CHECKas a core breaking-check option. - Passes the parsed option into
BreakingChecker.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
internal/core/breaking_checker.go |
Adds a filesCheck flag to the checker. |
internal/core/breaking_check.go |
Defines the FILES_CHECK option and passes config into the checker. |
internal/config/breaking_check.go |
Adds Use []string to breaking config. |
internal/api/temporaly_helper.go |
Parses breaking.use and maps FILES_CHECK to core config. |
example.easyp.yaml |
Shows breaking.use: [FILES_CHECK] in the example config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| against ProtoData | ||
| current ProtoData | ||
|
|
||
| filesCheck bool |
Comment on lines
+7
to
+8
| AgainstGitRef string `json:"against_git_ref,omitempty" yaml:"against_git_ref,omitempty"` | ||
| Use []string `json:"use,omitempty" yaml:"use,omitempty"` |
| linterIgnoreDirs := append(cfg.Lint.Ignore, vendorPath) | ||
| breakingCheckIgnoreDirs := append(cfg.BreakingCheck.Ignore, vendorPath) | ||
|
|
||
| filesCheck := slices.Contains(cfg.BreakingCheck.Use, core.BreakingCheckFilesCheck) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.