Skip to content

Conversation

@AndrewSazonov
Copy link
Member

Extends the show_analysis_chart and show_experiment_chart methods of the job object with the show_legend flag to show/hide the chart legend.

@AndrewSazonov AndrewSazonov added the [scope] enhancement Adds/improves features (major.MINOR.patch) label Oct 28, 2024
Copy link
Contributor

@celinedurniak celinedurniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndrewSazonov Thanks for the implementation.
Is there any reason why you did not add related tests?

@AndrewSazonov
Copy link
Member Author

This new functionality is added to one of the notebooks in the examples directory. All the notepads are run as tests on pull requests, and thus this is covered as well. But in general I agree, and we need to increase the coverage of EDL code with unit tests.

@AndrewSazonov AndrewSazonov merged commit 45411e5 into develop Oct 28, 2024
@AndrewSazonov AndrewSazonov deleted the chart_legend branch November 1, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[scope] enhancement Adds/improves features (major.MINOR.patch)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants