Skip to content

Conversation

@AndrewSazonov
Copy link
Member

  • Bump easycrystallography to 0.6.0
  • Bump easyscience to 1.1.1
  • Add urls to the experimental parameters
  • Fix units for parameters dtt1, dtt2, sigma1, sigma2, sigma3
  • Clean up project

@AndrewSazonov AndrewSazonov added [scope] bug Bug report or fix (major.minor.PATCH) [scope] enhancement Adds/improves features (major.MINOR.patch) labels Oct 31, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Member

@rozyczko rozyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor wording

# env:
# OS: ${{ matrix.os }}
# PYTHON: ${{ matrix.python-version }}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the upload doesn't work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this works partially and requires additional tests before enabling this step.

README.md Outdated
<img src="https://raw.githubusercontent.com/EasyScience/EasyDiffractionApp/master/resources/images/ed_logo.svg" height="65">

[![](http://github-actions.40ants.com/easyscience/easydiffractionlib/matrix.svg)](https://github.com/easyscience/easydiffractionlib/actions)
EasyDiffraction is a Python library for the calculation of neutron powder diffraction pattern based on a structural model and refinement of its parameters against experimental data.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... for calculating neutron powder... would probably sound better
also
... and for refining of its parameters...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

pyproject.toml Outdated

[tool.ruff.lint.per-file-ignores]
# allow asserts in test files
# allow asserting in test files
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asserts is a proper wording here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@AndrewSazonov AndrewSazonov merged commit ce92073 into develop Nov 1, 2024
@AndrewSazonov AndrewSazonov deleted the parameter_urls branch November 4, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[scope] bug Bug report or fix (major.minor.PATCH) [scope] enhancement Adds/improves features (major.MINOR.patch)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants