-
Notifications
You must be signed in to change notification settings - Fork 1
Bump easyscience and easycrystallography to releases and fix minor issues #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AndrewSazonov
commented
Oct 31, 2024
- Bump easycrystallography to 0.6.0
- Bump easyscience to 1.1.1
- Add urls to the experimental parameters
- Fix units for parameters dtt1, dtt2, sigma1, sigma2, sigma3
- Clean up project
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
rozyczko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor wording
| # env: | ||
| # OS: ${{ matrix.os }} | ||
| # PYTHON: ${{ matrix.python-version }} | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the upload doesn't work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, this works partially and requires additional tests before enabling this step.
README.md
Outdated
| <img src="https://raw.githubusercontent.com/EasyScience/EasyDiffractionApp/master/resources/images/ed_logo.svg" height="65"> | ||
|
|
||
| [](https://github.com/easyscience/easydiffractionlib/actions) | ||
| EasyDiffraction is a Python library for the calculation of neutron powder diffraction pattern based on a structural model and refinement of its parameters against experimental data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... for calculating neutron powder... would probably sound better
also
... and for refining of its parameters...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
pyproject.toml
Outdated
|
|
||
| [tool.ruff.lint.per-file-ignores] | ||
| # allow asserts in test files | ||
| # allow asserting in test files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
asserts is a proper wording here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed