Conversation
Fix multiple experiments display
ruff cleanup
showing fit status on error selecting fittables properly
rozyczko
added
[scope] enhancement
rozyczko
added a commit
that referenced
this pull request
Mar 9, 2026
* typo fixed (#258) * New easycore (#259) * changes for new easycore. * work on dependent parameters. * install libs before installing python deps * fixes for dependent parameters * added constraint display * remove constraint works now * CR fixes * Renaming a model (#260) * initial commit * only show enabled parameters * model name changes update Analysis * added experimental data explorer. WIP * more code for multiple experiments display * improved experiment-sample dialogs * improved performance of add model/rename model * rename experiments now works * fixed interactions in the analysis tab, experiment-model display * fixed parameter enablement for fitting, fixed typo * sped up switching between samples. fixed colors of samples on the Sample and Analysis pages * ruff - removed unused variable * added SLD display for Analysis * fix experiment deletion. * fixes after merge * Changing layers bug (#261) * removed references to `enabled` for parameters, causing the crash * remove macos-13 * updated lib branch * Multiple plots (#262) * don't loose experiment names on selection * remove debug printout. Add app icon * multiple display for analysis as well * initial version of the complex constraint editor * connect to backend * improved model colour handling * Added "Select All" checkbox for fit params * let's try unpinning pyside6 * separate experiment plots properly * staggered plots with checkbox control * added staggering distance slider * fix the validator. Add multi-model constraint UI * notify the layers of the name change * Account for subphase and superphase constraints * Move SLD underneath the main plot, as requested * add splitters in Sample and Analysis * reload the models after orso file load * use correct branch name * reparent ERL dependency. Fix multiple experiments display * reparent ERL * minor fixes after ERL update. ruff cleanup * multiplotting in Analysis * fixes to multiple sample loads * update ERL dependency * fix the SLD chart on the Analysis page * initial version of multiple sample plots (profile + sld) * fixed SLD display for added sample. Fixed tooltip display * implement the chart buttons functionality * allow reset on both sld and profile charts * fixed layers property table enablement * added Fit status dialog * fixes for: showing fit status on error selecting fittables properly * show the content of the dependent params combobox * added plot control subgroup with log q and reversed SLD x axis * missed file * more forgotten files * added logic for single-click multi-model constraints * attempt at making layer names consistent * PR fixes. Set #1 * Multifit functionality (#263) * threaded fitting + multifit initial impl * added multi-result aggregation * PR comments * CR comments #2 * Improved plots (#264) * plot control in Experiment and Analysis * added scale/bg lines to exp and analysis plots * Y axis label fix * fixed profile lines. * code review fixes * proper orso sample conversion into layers * added checkbox for loaded orso overwrite. fixed axes reset on file load * show ORSO name when available * model prefix based on its name * use orso name when available * enhance safety of ORSO sample file load * changes after CR * re-enable plot control widgets on Experiment and Analysis tabs * properly reset axes in the sample charts on any param change * reset axes for analysis SLD/Refl plots on parameter change. * update the status line with correct values * sample profile on Analysis should include resolution * refactor SldView so Sample and Analysis get the same display * logging for minimizer change * formatting for the error column * improved constraints check * added chi2 display in the status bar * PR review #2 * Allow multiple experiments in a single file. (#269) * allow multiple experiments in a single file. Fix the q coordinate in plots * mask the zero variance points like it's done in the lib * Version update in preparation for release (#268) * updated version string and what's new * correct ver. # * updates for the front page of the app * fixed cases for easyapp modules (#270) * fixed cases for easyapp modules * change max iter for minimizers to a more reasonable value (#271) * Reporting (#278) * added improved reporting, as in the previous version * review comments addressed * Filtering (#279) * added filtering as in the qt5 branch * fixed issue with combobox population * added missing dialog (#281) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: henrikjacobsenfys <henrik.jacobsen.fys@gmail.com> Co-authored-by: Andrew Sazonov <andrew.sazonov@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing qt5 version functionality