Conversation
bar. Reparented to EDL develop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the handling and visualization of residuals in the EasyReflectometryApp, along with several backend enhancements and bug fixes.
Residuals computation and plotting:
plotting_1d.pyto compute residual ranges (residualMinX,residualMaxX,residualMinY,residualMaxY) and provide normalized residual data points for plotting. These are now exposed to QML and updated when analysis data changes.Plotting.qml) to include stub properties and a function for residual ranges and data points, supporting frontend development and testing.py_backend.py) for retrieving residual data points from QML, enabling integration of the new residual chart.Experiment loading and q-range synchronization:
project.py,experiment.py) to return a boolean indicating if the q-range changed, and emit a newqRangeUpdatedsignal when necessary. This ensures the frontend stays in sync with backend data changes.q_maxbased on the largest q-value in loaded experiments, improving data consistency.Fitting and parameter display improvements:
Other backend enhancements and fixes:
calculatorproperty for better encapsulation.models.pyto use a getter, improving maintainability.helpers.py.project.py.py_backend.pyto ensure parameters and experiments are refreshed correctly on model table changes, and to propagate q-range updates.