Add support for more math functions for Parameters and DescriptorNumbers #297
henrikjacobsenfys
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This is to flesh out ideas for implementing #201
General
Right now, we support a few functions on parameters: add, sub, mul, div, pow, neg, abs. That's great, but we need a lot more: exp, trigonometric functions, sqrt, arguably also more complex ones like erf.
Idea
Make a class (
MathFunctions?) to handle all the functions. It just needs to point at the scipp functions for most calculations, and handle propagation of bounds properly (see below). We can also point it at numpy functions to help us with speeding up calculations with dependent parameters by building in calculations that bypass the slow unit handling while still giving the right result (#298 ), and with implementing correct error propagation for dependent parameters (#299).Bounds
Propagating the bounds for trigonometric functions can be handled in two ways.
All reactions