-
Notifications
You must be signed in to change notification settings - Fork 0
Unify CIF parsing, category updates, and data handling #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…em with categories property
…ates experiment handling in factory methods
…or clarity and consistency
…is and experiment modules
…update logic for plotting methods
…culations and update methods for improved data handling
…tions and simplifying experiment data handling
…handling; removes obsolete ScDatastore class
…implifies fitting method; deletes obsolete datastore test files
…add 'id' parameter
…et default values for parameters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #108 +/- ##
===========================================
+ Coverage 81.31% 82.26% +0.94%
===========================================
Files 89 88 -1
Lines 5117 5451 +334
Branches 412 454 +42
===========================================
+ Hits 4161 4484 +323
+ Misses 810 802 -8
- Partials 146 165 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a substantial refactor of CIF parsing, data handling, and category update logic across the codebase.
Key changes include: