Initial implementation of the crystal structure visualization#186
Merged
Conversation
Cover the new single_crystal_axis_range / single_crystal_tick_step helpers, the data-coordinate diagonal and smaller markers/error bars in the Plotly trace, and the shared x/y range, tick step, and diagonal colour in the report fit-plot context.
Round the shared tick step to the nearest 1/2/5 power of ten and anchor ticks at 0, so both axes read 0, 500, ..., 2500 (was 750-spaced from the padded minimum). Colour the marker stroke like the fill to drop the ring, and thin the error-bar line and caps.
Add a regression that the padded heidi range rounds to a 500 step (not 750) and assert the marker stroke colour matches the fill.
AndrewSazonov
added
the
[scope] enhancement
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #186 +/- ##
===========================================
+ Coverage 85.35% 86.01% +0.66%
===========================================
Files 235 258 +23
Lines 20300 21631 +1331
Branches 2383 2518 +135
===========================================
+ Hits 17327 18606 +1279
- Misses 2054 2071 +17
- Partials 919 954 +35
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.