Conversation
rozyczko
approved these changes
May 25, 2021
Member
rozyczko
left a comment
There was a problem hiding this comment.
Minor issues remain to be fixed but the main functionality is working fine.
One more general observation: when the maintenance tool is running, attempting to use the Quit button still presents me with the UAC dialog "Would you like the application to make changes to your computer?" despite saying no. There is no installation going on, just the annoying dialog which should not be there.
| onCheckedChanged: EaGlobals.Variables.checkUpdateOnAppStart = checked | ||
| EaElements.Label { | ||
| anchors.verticalCenter: parent.verticalCenter | ||
| text: qsTr("Check on app start") + ":" |
Member
There was a problem hiding this comment.
Check of application start would sounds more professional. App has mobile software connotations, I think
| matches = re.findall(pattern, web_changelog) | ||
| web_date = matches[0] | ||
| return web_date | ||
|
|
Member
There was a problem hiding this comment.
QApplication.quit() in installUpdate in line 70 will need user confirmation if state is changed.
rozyczko
reviewed
May 25, 2021
Member
Member
Author
Overdue merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Work related to:
Extra:
easyAppGuiandeasyAppLogicare now merged intoeasyApp