Skip to content

Updater #1

Merged
rozyczko merged 28 commits intomasterfrom
develop
Feb 3, 2022
Merged

Updater #1
rozyczko merged 28 commits intomasterfrom
develop

Conversation

@AndrewSazonov
Copy link
Copy Markdown
Member

Work related to:

Extra:

  • easyAppGui and easyAppLogic are now merged into easyApp
  • Redesigned application preferences dialog

Copy link
Copy Markdown
Member

@rozyczko rozyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issues remain to be fixed but the main functionality is working fine.
One more general observation: when the maintenance tool is running, attempting to use the Quit button still presents me with the UAC dialog "Would you like the application to make changes to your computer?" despite saying no. There is no installation going on, just the annoying dialog which should not be there.

onCheckedChanged: EaGlobals.Variables.checkUpdateOnAppStart = checked
EaElements.Label {
anchors.verticalCenter: parent.verticalCenter
text: qsTr("Check on app start") + ":"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check of application start would sounds more professional. App has mobile software connotations, I think

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Comment thread easyApp/Logic/Maintenance.py
matches = re.findall(pattern, web_changelog)
web_date = matches[0]
return web_date

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QApplication.quit() in installUpdate in line 70 will need user confirmation if state is changed.

Comment thread easyApp/Logic/Maintenance.py
@rozyczko
Copy link
Copy Markdown
Member

When running the update, the component display of items to be updated is less than optimal:

app

@AndrewSazonov
Copy link
Copy Markdown
Member Author

When running the update, the component display of items to be updated is less than optimal:

app

I have disabled this page as it is not really needed anyway.

@rozyczko rozyczko merged commit 66f362f into master Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants