Conversation
* assure refl1d actually runs from the GUI * don't fail on codecov upload
* initial implementation * set `disable` status on relevant sub/super-phase parameters * fixed tests * fixes after CR * fixed tests
* initial implementation of the mighell algorithm for data with zero variances * don't fail on codecov upload * fixed chi2 reporting, added MD file with description * unit test update * added docs about Mighell * updated easyscience branch, deleted script * chi -> chi2 * use develop for core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the handling of zero-variance data points in fitting routines, adds comprehensive documentation for new fitting objectives, and enhances the fitting tutorial to demonstrate backend comparisons. The most important changes include the implementation of Mighell-based objective handling, expanded documentation and user guidance, and updates to the fitting tutorial for clarity and reproducibility.
Fitting objective enhancements:
objective='legacy_mask'. Introduced a newobjectiveparameter onMultiFitter,fit(), andfit_single_data_set_1d().Documentation improvements:
Added a new API documentation page for fitting helpers and objective functions, including detailed explanations of Mighell, hybrid, and legacy objective modes, their mathematical basis, and guidance for users.
Updated the changelog to document the new zero-variance handling and objective parameter.
Tutorial updates:
Enhanced the simple fitting tutorial notebook to include both
refnxandrefl1dbackends, showing how to rebuild the model for each and compare results, with clearer output and improved reproducibility.Other changes:
.github/workflows/python-ci.yml)