ElasticSearch - For partial updates with update generated values (@WhenModified) and when that property we want to include that in the update message to ElasticSearch

[rbygrave]

This might be a Refactor or a Bug even but if a partial update does not have the @WhenModified property loaded then the SQL update will include it (as expected) but the dirtyProperties set does not.

This has lead to a tidy up because since 4.x we dropped "All values optimistic concurrency checking" so the only properties in an update where clause are now the @id and @Version ... so the code in BindablePropertyUpdateGenerated has been simplified due to that change.

[rbygrave]

So given the Product entity bean has a @WhenModified property then the partial updates include it in the message to ElasticSearch:

    Product partial = Ebean.find(Product.class)
        .select("name")
        .where().idEq(prod.getId())
        .findUnique();

    partial.setName("Mighty Keyboard");
    Ebean.save(partial);

    assertThat(Ebean.getBeanState(partial).getLoadedProps()).contains("whenModified");
    assertThat(Ebean.getBeanState(partial).getLoadedProps()).doesNotContain("version");

[rbygrave]

In the case where the partial object has the version property then:

    Product partialWithVersion = Ebean.find(Product.class)
        .select("name,version")
        .where().idEq(prod.getId())
        .findUnique();

    partialWithVersion.setName("Silly Keyboard");
    Ebean.save(partialWithVersion);

    assertThat(Ebean.getBeanState(partialWithVersion).getLoadedProps()).contains("whenModified", "version");