Add support for literal mode for InTuples with lots of entries#3165
Merged
rob-bygrave merged 1 commit intomasterfrom Aug 16, 2023
Merged
Add support for literal mode for InTuples with lots of entries#3165rob-bygrave merged 1 commit intomasterfrom
rob-bygrave merged 1 commit intomasterfrom
Conversation
So as to not exceed the limit on bind values, the InTuples expression can go into literal mode where it uses literal values for supported types - Numbers, Strings, UUID, and LocalDate.
rob-bygrave
reviewed
Aug 16, 2023
| for (String property : properties) { | ||
| builder.append(property).append("-"); | ||
| if (literalMode) { | ||
| builder.append(UUID.randomUUID()); |
Contributor
There was a problem hiding this comment.
Could look for improvement here. This is here to defeat the ebean internal compiled query plan cache. It has a default TTL of 5 mins and query execution stats are collected in background. An improvement here might effectively disable the ability to collect query plans (if the compiled query plan is removed quickly) but maybe that is better than holding the compiled query plan that is never expected to be reused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So as to not exceed the limit on bind values, the InTuples expression can go into literal mode where it uses literal values for supported types - Numbers, Strings, UUID, and LocalDate.