fix: Send the correct data for on callbacks#6
Merged
ebebbington merged 13 commits intomasterfrom Aug 17, 2020
Merged
Conversation
added 9 commits
August 16, 2020 15:03
added 2 commits
August 17, 2020 01:35
ebebbington
changed the title
on callbacks
added 2 commits
August 17, 2020 01:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5
Decided against having a trigger method, but the code exists (just commented out) as i felt it wasnt actually needed. Instead i reworked the internal code that will now properly send the correct event data back, such as the correct calls to a
peerEntryhandler