Make navigation bolding current-only

[ebelo]

Summary

• align left navigation typography with the design-system rule that only the selected/current page is bold
• keep ready-but-unselected pages neutral while preserving their text color/status metadata
• add UI shell coverage for ready navigation font weight

Tests

• python3 -m pytest tests/test_local_first_shell.py -q
• python3 -m pytest tests/ -x -q --tb=short

Local validation

• Deployed this branch to the Windows QGIS default plugin folder for local testing.

[greptile-apps]

Greptile Summary

This PR narrows bold font weight in the left navigation so that only the selected (current) page uses font-weight: 700; pages that are ready-but-unselected are reduced from 600 to 500, matching the unready (available) tone. A companion test assertion confirms the new 500 value for the ready state.

• local_first_shell.py — _navigation_item_stylesheet changes the "ready" branch from font_weight = "600" to font_weight = "500", aligning it with the "available" branch.
• test_local_first_shell.py — adds assertIn("font-weight: 500", data_item.styleSheet()) to the existing navigation-state test to lock in the new weight.

Confidence Score: 5/5

Safe to merge — one-line cosmetic change with a test backing it up.

The change is a single font-weight value swap in a stylesheet helper, isolated to the "ready" navigation tone. The new test assertion directly exercises the changed line. The only gap is a missing symmetric assertion for the "current" item's bold weight, which is a minor coverage observation rather than a functional concern.

No files require special attention.

Important Files Changed

Filename	Overview
ui/dockwidget/local_first_shell.py	Single-line change: "ready" tone font_weight lowered from "600" to "500", matching the "available" tone and leaving "current" as the sole bold (700) item.
tests/test_local_first_shell.py	Adds assertIn("font-weight: 500", data_item.styleSheet()) for the "ready" state; the complementary assertion that the current item carries font-weight: 700 is absent.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[_nav_tone] -->|page_state.current| B["tone = 'current'"]
    A -->|page_state.ready| C["tone = 'ready'"]
    A -->|otherwise| D["tone = 'available'"]

    B --> E["font-weight: 700\nbackground: COLOR_TITLE_BAR\ncolor: COLOR_TEXT"]
    C --> F["font-weight: 500 ← changed from 600\nbackground: transparent\ncolor: COLOR_TEXT"]
    D --> G["font-weight: 500\nbackground: transparent\ncolor: COLOR_MUTED"]

Loading

_{Reviews (1): Last reviewed commit: "Make nav bolding current-only" | Re-trigger Greptile}

[greptile-apps]

The new assertion validates that the ready state drops to font-weight: 500, but there is no matching assertion that the current (map_item) state still carries font-weight: 700. Without it, a future accidental change to the current tone's weight would go undetected by this test.

Suggested change

	self.assertTrue(data_item.property("ready"))
	self.assertEqual(data_item.property("navTone"), "ready")
	self.assertIn("font-weight: 500", data_item.styleSheet())
	self.assertTrue(map_item.property("current"))
	self.assertEqual(map_item.property("navTone"), "current")
	self.assertTrue(data_item.property("ready"))
	self.assertEqual(data_item.property("navTone"), "ready")
	self.assertIn("font-weight: 500", data_item.styleSheet())
	self.assertTrue(map_item.property("current"))
	self.assertEqual(map_item.property("navTone"), "current")
	self.assertIn("font-weight: 700", map_item.styleSheet())

[ebelo]

Thanks — agreed. Added the symmetric assertion that the current navigation item keeps font-weight: 700, alongside the ready item's font-weight: 500 assertion.

Re-ran:

• python3 -m pytest tests/test_local_first_shell.py -q
• python3 -m pytest tests/ -x -q --tb=short

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud