Expose style controls in local-first Map page

[ebelo]

Summary

• Add a local-first Map-page slot for activity style controls.
• Move the existing style preset label/combo into that visible Map-page slot for both wizard and local-first compositions.
• Cover the migrated control placement in pure page/dock tests and QGIS smoke coverage.

Refs #805.

Tests

• python3 -m pytest tests/test_map_page.py tests/test_qfit_dockwidget_analysis_pure.py tests/test_qgis_smoke.py::QgisSmokeTests::test_dock_widget_defaults_to_local_first_live_path -q
• python3 -m pytest tests/ -x -q --tb=short

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[greptile-apps]

Greptile Summary

This PR exposes the activity-style preset label and combo box inside the local-first (and wizard) map-page slot by introducing a style_controls_panel to MapPageContent and a new _install_wizard_style_controls installer on QfitDockWidget, following the identical pattern already established for filter controls.

• ui/dockwidget/map_page.py: Adds style_controls_panel, _build_style_controls_layout, style_controls_layout(), and set_style_controls_visible() mirroring the existing filter-panel API; set_state now calls set_style_controls_visible() on every refresh.
• qfit_dockwidget.py: Adds _install_wizard_style_controls with the same idempotency guard (id(map_content)) and widget re-parenting strategy as _install_wizard_filter_controls, and calls it for both the wizard and local-first compositions.
• Tests: Pure unit, map-page, and QGIS smoke coverage is added for all new behaviour.

Confidence Score: 5/5

Safe to merge — the change is a straightforward, well-tested extension of the existing filter-controls pattern with no regressions identified.

The new _install_wizard_style_controls method and style_controls_panel additions faithfully replicate the already-proven _install_wizard_filter_controls design. Idempotency guards, widget re-parenting, and visibility handling are all consistent. Tests cover initial state, the install path, idempotency, state refresh, and end-to-end QGIS smoke — no gaps found.

No files require special attention.

Important Files Changed

Filename	Overview
ui/dockwidget/map_page.py	Adds style_controls_panel and associated layout/visibility helpers to MapPageContent, mirroring the existing filter_controls_panel pattern cleanly.
qfit_dockwidget.py	Adds _install_wizard_style_controls and wires it into both the wizard and local-first compositions; idempotency guard, re-parenting, and visibility handling follow the established filter-controls pattern exactly.
tests/test_map_page.py	Extends existing map-page tests to cover style_controls_panel initial state, set_style_controls_visible, and persistence through set_state.
tests/test_qfit_dockwidget_analysis_pure.py	Adds pure unit tests for _install_wizard_style_controls (move path and idempotency) and mocks the new call in the local-first composition build test.
tests/test_qgis_smoke.py	Adds QGIS smoke assertions verifying stylePresetComboBox is parented to the local-first map page's style_controls_panel and indexed within its layout after composition build.

Sequence Diagram

sequenceDiagram
    participant DW as QfitDockWidget
    participant Comp as Composition (wizard / local-first)
    participant MPC as MapPageContent
    participant SCP as style_controls_panel (QWidget)
    participant SCL as _style_controls_layout (QVBoxLayout)

    DW->>Comp: build_*_composition()
    Comp->>MPC: MapPageContent(state)
    MPC->>SCP: QWidget(self) + setObjectName
    MPC->>SCL: QVBoxLayout(style_controls_panel)
    MPC->>MPC: set_state() → set_style_controls_visible()
    MPC-->>Comp: map_content

    DW->>DW: _install_wizard_style_controls(composition)
    DW->>DW: guard: _wizard_style_controls_installed and target == id(map_content)?
    alt already installed for this map_content
        DW-->>DW: return early (idempotent)
    else first install / new target
        DW->>DW: _remove_widget_from_current_layout(stylePresetLabel)
        DW->>SCP: stylePresetLabel.setParent(style_controls_panel)
        DW->>SCL: addWidget(stylePresetLabel)
        DW->>DW: _remove_widget_from_current_layout(stylePresetComboBox)
        DW->>SCP: stylePresetComboBox.setParent(style_controls_panel)
        DW->>SCL: addWidget(stylePresetComboBox)
        DW->>MPC: set_style_controls_visible()
        DW->>DW: _wizard_style_controls_installed = True
    end

Loading

_{Reviews (1): Last reviewed commit: "Expose style controls in local-first map..." | Re-trigger Greptile}