Skip to content

Fix #345 : allows keystore of types ETOKEN|PKCS11 to be reloaded more than once until an alias is successfully fetched.#346

Open
Macadoshis wants to merge 3 commits into
ebourg:masterfrom
Macadoshis:fixes/345
Open

Fix #345 : allows keystore of types ETOKEN|PKCS11 to be reloaded more than once until an alias is successfully fetched.#346
Macadoshis wants to merge 3 commits into
ebourg:masterfrom
Macadoshis:fixes/345

Conversation

@Macadoshis
Copy link
Copy Markdown

@Macadoshis Macadoshis commented May 12, 2026

Fix #345

@Macadoshis
Fix ebourg#345 : allows keystore of types ETOKEN|PKCS11 to be reloade…
7e5720b 
…d more than once until an alias is successfully fetched.
@Macadoshis Macadoshis mentioned this pull request May 12, 2026
Open
@ebourg
Copy link
Copy Markdown
Owner

ebourg commented May 12, 2026

The patch looks fine, thank you. Could you modify it slightly to:

  • Use the same max attempt value for all storetypes, I don't think we'll need to customize it per storetype. The value can be hardcoded in the build() method.
  • document in the build() method why the retry mechanism is necessary, with a reference to the related GitHub Issue.

@ebourg ebourg added this to the 7.5 milestone May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

7.5

Development

Successfully merging this pull request may close these issues.

Empty keystore with SafeNet eToken 5110+ FIPS accessed through PKCS#11 (eTPKCS11.dll)

2 participants

@Macadoshis @ebourg