Skip to content

improvement: lower gibs bounceFactor#63

Open
WofWca wants to merge 3 commits intoec-:masterfrom
WofWca:baseq3a-gibs-lower-bounce-factor
Open

improvement: lower gibs bounceFactor#63
WofWca wants to merge 3 commits intoec-:masterfrom
WofWca:baseq3a-gibs-lower-bounce-factor

Conversation

@WofWca
Copy link
Contributor

@WofWca WofWca commented Nov 18, 2025

This MR is based on #62, which I suggest to review and merge first.
However, if you for whatever reason dislike that MR
and like this one, I can rebase it, i.e. remove the CVAR.

This makes the gibs feel more "dead" and less frog-like.

This is primarily intended to be useful together with #53.

This is in preparation to some gibs improvements.
This makes the gibs feel more "dead" and less frog-like.
@LegendaryGuard
Copy link
Contributor

LegendaryGuard commented Jan 8, 2026

All these gib features look pretty cool, excellent work!
I understand the enthusiasm and dedication you have put into this. :)
But if you don't mind, when you've time, could you try to join all the PRs related to the gibs features into just one PR?

It's complicated and confusing to trace and implement this correctly included all the details like cvars, tweaks and fixes.
Looks like @ec- (the maintainer and owner) isn't comfortable to review all that and doesn't know how to start. 😅

And @ensiform is right, no need to separate all.
It's not because a big PR isn't easy to review all that, but because it's easier to review the code files one per one inside a PR.
So, you don't need to worry about it being a very big PR; anyone is willing to look at it in detail without any trouble.
;)

@WofWca
Copy link
Contributor Author

WofWca commented Jan 9, 2026

Thank you! Glad to hear that you're open to the changes!

As I said, my MRs are self-contained, unless I otherwise noted, so they can just be merged individually.

But yes, sure, I'll put them all in one big beautiful MR within some days.

@WofWca WofWca mentioned this pull request Jan 9, 2026
@ec-
Copy link
Owner

ec- commented Jan 26, 2026

Looks like @ec- (the maintainer and owner) isn't comfortable to review all that and doesn't know how to start. 😅

I have very little time to be even with electric supply and this is not funny at all, just note that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants