Keep ordering of checklist items when copying from prototype#9007
Merged
carlobeltrame merged 1 commit intoecamp:develfrom Feb 6, 2026
Merged
Conversation
carlobeltrame
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
✅ Feature branch deployment ready!
|
BacLuc
approved these changes
Feb 6, 2026
simfeld
approved these changes
Feb 6, 2026
carlobeltrame
force-pushed
the
fix-checklist-order-after-copying-template
branch
from
4c35593 to
235d757
Compare
carlobeltrame
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we didn't copy the
positionattribute from ChecklistItem prototypes. If the items were created in order (and you were lucky), the DB would return the items in order duringChecklist#copyFromPrototype. But if some of the items in the checklist prototype were created or reordered later, it was not guaranteed that the order of the copied checklist items matches the order of the prototype checklist items.Since the numbering of the checklist items is quite important for PBS courses, this is a problem.