Skip to content

Quick share improvements#3169

Merged
feruzm merged 6 commits intodevelopmentfrom
quick
Apr 15, 2026
Merged

Quick share improvements#3169
feruzm merged 6 commits intodevelopmentfrom
quick

Conversation

@feruzm
Copy link
Copy Markdown
Member

@feruzm feruzm commented Apr 14, 2026

Summary by CodeRabbit

Release Notes

  • New Features

    • Added share intent selection flow allowing users to choose between sharing as a blog post or quick wave update.
    • Enabled file sharing support in quick post creation.
  • Improvements

    • Enhanced delegation functionality to accurately track existing vesting share allocations and allow users to adjust or remove delegations.
    • Updated slider component dependency for better compatibility and reliability across the app.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 14, 2026

Warning

Rate limit exceeded

@feruzm has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 22 minutes and 55 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 22 minutes and 55 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0f4b1867-d79e-4d7d-9d8e-9ab63f40e63c

📥 Commits

Reviewing files that changed from the base of the PR and between 5ace645 and b3e89f1.

📒 Files selected for processing (1)
  • src/screens/transfer/screen/delegateScreen.tsx
📝 Walkthrough

Walkthrough

This PR introduces a share-intent selection flow allowing users to choose between blog post and wave sharing, updates the quick post modal to handle shared files, migrates slider dependencies to a community-maintained package across multiple components, and adds sheet registration infrastructure for the new share intent sheet.

Changes

Cohort / File(s) Summary
Share Intent UI Components
src/components/shareIntentSheet/shareIntentSheet.tsx, src/components/shareIntentSheet/index.ts
New ActionSheet component that displays blog post and wave sharing options with localized strings; includes named export for module access.
Quick Post Modal Updates
src/components/quickPostModal/quickPostModal.tsx, src/components/quickPostModal/quickPostModalContent.tsx
Modified to extract and pass files from payload; quickPostModalContent filters files into sharedMediaFiles and injects text/weblink concatenation into comment value.
Navigation & Sheet Registration
src/navigation/sheets.tsx
Added SHARE_INTENT enum entry and registered the ShareIntentSheet; extended type definitions for SHARE_INTENT (payload with files array) and updated QUICK_POST payload to include optional files.
Share Intent Routing
src/screens/application/container/applicationContainer.tsx
Changed share handler to present ShareIntentSheet first; routes resolved selection (blog/wave) to appropriate target (editor or quick-post modal) with shared files.
Localization
src/config/locales/en-US.json
Added share_intent locale object with strings for title, blog post, and wave sharing options.
Slider Dependency Migration
src/components/textToSpeech/ttsSettingsSheet.tsx, src/components/upvotePopover/container/upvotePopover.tsx, src/screens/transfer/screen/powerDownScreen.tsx, src/screens/transfer/screen/withdrawAccountModal.tsx
Replaced @esteemapp/react-native-slider import with @react-native-community/slider; removed trackStyle/thumbStyle props and added maximumTrackTintColor styling.
Delegation Logic & Slider Update
src/screens/transfer/screen/delegateScreen.tsx
Added delegatedVests state to track existing vesting shares; updated validation to allow zero HP when delegated shares exist; computed effectiveMaxVests for slider bounds; migrated slider dependency and props.
Dependency Updates
package.json, patches/@esteemapp+react-native-slider+0.12.0.patch
Removed @esteemapp/react-native-slider (^0.12.0), added @react-native-community/slider (^5.2.0); pinned react-native-slider to exact 0.11.0; patch file references removed (no longer needed).

Sequence Diagram

sequenceDiagram
    participant User
    participant AppContainer as ApplicationContainer
    participant SheetMgr as SheetManager
    participant ShareSheet as ShareIntentSheet
    participant QuickPost as QuickPostModal/Editor
    
    User->>AppContainer: Trigger share intent (files)
    AppContainer->>SheetMgr: show(SHARE_INTENT, {files})
    SheetMgr->>ShareSheet: Display sheet
    ShareSheet->>User: Show blog/wave options
    User->>ShareSheet: Select option (blog|wave)
    ShareSheet->>SheetMgr: hide(sheetId, {payload: target})
    alt Blog selected
        SheetMgr->>AppContainer: Return 'blog'
        AppContainer->>QuickPost: Navigate to EDITOR with files
    else Wave selected
        SheetMgr->>AppContainer: Return 'wave'
        AppContainer->>QuickPost: Show QUICK_POST sheet with files
    end
    QuickPost->>User: Display editor/modal with shared content
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • #3147: Adds AI Assist integration and toolbar changes to quickPostModalContent.tsx, which is also modified in this PR for file handling.
  • #3103: Refactors comment input imperative handle and state in the same quickPostModalContent.tsx component.
  • #3137: Modifies delegation-related state and slider logic in delegateScreen.tsx, overlapping with delegation vesting changes in this PR.

Suggested labels

deploy-pr-build

Poem

🐰 A hop, a share, a choice so bright,
Blog or wave—the user's delight!
Files now flutter through the flow,
While sliders migrate to steal the show! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Quick share improvements' is vague and generic, using non-descriptive language that doesn't convey the specific technical changes made in the changeset. Consider a more specific title that describes the main change, such as 'Add share intent sheet for blog/wave selection' or 'Implement file sharing with format selection modal'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch quick

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

@feruzm feruzm merged commit aca162d into development Apr 15, 2026
4 of 6 checks passed
@feruzm feruzm deleted the quick branch April 15, 2026 15:08
@coderabbitai coderabbitai Bot mentioned this pull request Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant