Skip to content

Version bump#638

Merged
feruzm merged 4 commits into
developfrom
vbump
Feb 2, 2026
Merged

Version bump#638
feruzm merged 4 commits into
developfrom
vbump

Conversation

@feruzm
Copy link
Copy Markdown
Member

@feruzm feruzm commented Feb 2, 2026

Summary by CodeRabbit

  • New Features

    • Added owner-restriction to token operations (access control) and a default currency behavior.
  • Refactor

    • Improved type safety for wallet and portfolio data handling.
  • Chores

    • CI updated to rebuild affected packages when releases change.
    • Package versions and changelogs bumped for this release.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 2, 2026

📝 Walkthrough

Walkthrough

Stronger TypeScript typings added for Vision Portfolio data across three wallet query modules; getTokenOperationsQueryOptions gained an isForOwner parameter and defaulted currency behavior. CI workflow added a "Rebuild affected packages" step. Package versions and changelogs bumped for sdk and wallets. No runtime behavior changes beyond access gating in token operations.

Changes

Cohort / File(s) Summary
Vision Portfolio Type Annotations
packages/wallets/src/modules/wallets/queries/get-account-wallet-asset-info-query-options.ts, packages/wallets/src/modules/wallets/queries/get-tokens-operations-query-options.ts, packages/wallets/src/modules/wallets/queries/use-get-account-wallet-list-query.ts
Imported and applied VisionPortfolioResponse and VisionPortfolioWalletItem types; tightened typings for portfolio lookups, asset items, rawActions and action id extraction; ensured type-safe filters and deduplication. Added isForOwner parameter and default currency in getTokenOperationsQueryOptions.
CI workflow
.github/workflows/auto-changeset.yml
Added "Rebuild affected packages" step that detects package.json diffs for sdk/wallets/render-helper and conditionally builds @ecency/sdk, @ecency/wallets, @ecency/render-helper in order using pnpm filters.
Version bumps & changelogs
packages/sdk/package.json, packages/sdk/CHANGELOG.md, packages/wallets/package.json, packages/wallets/CHANGELOG.md
Bumped sdk and wallets packages to 1.5.23 and added changelog entries for the version bumps; no API changes beyond typing and internal edits.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Poem

🐰 I hopped through types with nimble paws,
Portfolio shapes and guarded laws,
A toggle for owners, tidy and neat,
CI hums builds on repeat,
Hooray — strong types, no missing claws! 🥕

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'Version bump' is vague and generic, failing to convey meaningful information about the specific changes beyond a version increment. Provide a more descriptive title that explains what was actually changed, such as 'Add Vision Portfolio typing and access control to wallet queries' to better reflect the substantive code changes.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch vbump

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]

This comment was marked as resolved.

@feruzm feruzm added the patch Bug fixes and patches (1.0.0 → 1.0.1), add this only if any packages/ have patch changes in PR label Feb 2, 2026
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @.github/workflows/auto-changeset.yml:
- Around line 148-151: The comment claims we're "checking git diff on
package.json versions" but the grep lines (checking "^packages/sdk/",
"^packages/wallets/", "^packages/render-helper/") match any file in those
directories; update either the comment to reflect we're checking any file under
those packages or narrow the greps to target package.json specifically (e.g.
grep for "^packages/sdk/package.json" etc.) and keep the CHANGED_PACKAGES
assignment logic (CHANGED_PACKAGES="$CHANGED_PACKAGES sdk") unchanged so the
behavior remains consistent with the intent.
🧹 Nitpick comments (3)
packages/wallets/src/modules/wallets/queries/get-tokens-operations-query-options.ts (3)

35-46: Type annotation doesn't match the defensive runtime handling.

Line 35 types rawActions as Array<{ id: string; ... }>, requiring id to always be present. However, the map callback at line 37 handles strings, and line 42 falls back to code, name, or action when id is absent. Consider aligning the type with the actual data shape.

♻️ Suggested type alignment
-        const rawActions: Array<{ id: string; [key: string]: unknown }> = assetEntry.actions ?? [];
+        const rawActions: Array<{ id?: string; [key: string]: unknown } | string> = assetEntry.actions ?? [];
         const operations: AssetOperation[] = rawActions
-          .map((action: { id: string; [key: string]: unknown } | string) => {
+          .map((action) => {

138-139: Avoid as any cast; prefer type extension.

Using as any bypasses type safety. If savings is a legitimate property of wallet items, consider extending VisionPortfolioWalletItem or using a type guard.

♻️ Suggested approach
-        const rawToken = assetEntry as any;
-        const hasSavings = Number(rawToken.savings ?? 0) > 0;
+        const hasSavings = Number((assetEntry as { savings?: number }).savings ?? 0) > 0;

Or better, if savings is common, extend the type at the source.


151-153: Silent error swallowing may hide issues.

The empty catch block returns an empty array without logging, which could obscure API failures or configuration issues. Consider adding minimal logging for observability.

🔍 Suggested improvement
-      } catch {
+      } catch (error) {
+        console.warn(`[getTokenOperationsQueryOptions] Failed to fetch operations for ${token}:`, error);
         return [];
       }

Comment thread .github/workflows/auto-changeset.yml
@feruzm feruzm merged commit 0e31f9a into develop Feb 2, 2026
1 check passed
@feruzm feruzm deleted the vbump branch February 2, 2026 11:44
@coderabbitai coderabbitai Bot mentioned this pull request Feb 18, 2026
This was referenced Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Bug fixes and patches (1.0.0 → 1.0.1), add this only if any packages/ have patch changes in PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant