New Crowdin updates#647
Conversation
📝 WalkthroughWalkthroughThis pull request updates internationalization strings across 22 locale files. Two translation keys are modified: Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
apps/web/src/features/i18n/locales/lt-LT.json (1)
196-196:⚠️ Potential issue | 🟡 MinorUntranslated string: "Direct Message Privacy" remains in English for Lithuanian locale.
This value and several surrounding DM-privacy strings (lines 1197–1204) are in English rather than Lithuanian. If this is a Crowdin sync with translations pending, this is fine as-is — just flagging for awareness.
apps/web/src/features/i18n/locales/it-IT.json (1)
196-196:⚠️ Potential issue | 🟡 MinorItalian capitalization convention: prefer sentence case.
"Privacy Del Messaggio Diretto" uses English-style title case. In Italian, standard convention capitalizes only the first word: "Privacy del messaggio diretto". This pattern should ideally be consistent across all Italian UI strings.
🤖 Fix all issues with AI agents
In `@apps/web/src/features/i18n/locales/hi-IN.json`:
- Line 1196: The hi-IN locale contains English text for the keys whose values
are "Direct Message Privacy" and "Add new keys"; update the hi-IN.json entries
for these keys by replacing the English strings with correct Hindi translations
(e.g., translate "Direct Message Privacy" and "Add new keys" into Hindi) or, if
these are intentionally left as source strings awaiting translators, add a clear
TODO/comment and confirm this is expected across all non-English locales; locate
and update the specific JSON keys matching those exact values to keep the locale
consistent.
In `@apps/web/src/features/i18n/locales/lt-LT.json`:
- Line 3119: The "add-key" translation in lt-LT.json is still in English; update
the value for the "add-key" key to the proper Lithuanian translation (e.g.,
"Pridėti naujus raktus") so the Lithuanian locale contains a localized string
for that key.
🧹 Nitpick comments (6)
apps/web/src/features/i18n/locales/tr-TR.json (2)
1196-1196: Translation missing: English string in Turkish locale.This value is
"Direct Message Privacy"(English) rather than a Turkish translation. Many other strings in thesettings.dm-privacyblock (lines 1197–1201) are also English, so this appears to be a pre-existing pattern of untranslated keys. Consider providing a Turkish translation (e.g.,"Doğrudan Mesaj Gizliliği") to keep the locale consistent for Turkish-speaking users.
3119-3119: Translation missing: English string in Turkish locale.Same issue —
"Add new keys"is English rather than Turkish. A Turkish equivalent (e.g.,"Yeni anahtarlar ekle") would improve consistency for this locale.apps/web/src/features/i18n/locales/id-ID.json (1)
3119-3119: Both updated strings remain in English in the Indonesian locale — consistent with existing pattern.The values for
settings.dm-privacy.title(Line 196) andpermissions.keys.add-key(Line 3119) are English rather than Indonesian. This matches many other untranslated keys in this file, so it's fine for now as Crowdin placeholders, but they should eventually receive proper Indonesian translations.apps/web/src/features/i18n/locales/yo-NG.json (1)
1196-1196: Both updated strings remain in English in the Yoruba (yo-NG) locale.Lines 1196 and 3119 use English text (
"Direct Message Privacy"and"Add new keys") rather than Yoruba translations. While other strings in this file also remain untranslated, this is worth noting since the PR description states the changes provide "language-appropriate equivalents for each locale."This is consistent with the existing pattern in this file where many strings are untranslated, so it may be intentional — just flagging for awareness.
Also applies to: 3119-3119
apps/web/src/features/i18n/locales/uz-UZ.json (2)
196-196: Untranslated string in Uzbek locale.
"Direct Message Privacy"is English, not Uzbek. Many other keys in this file are properly translated (e.g., the surrounding"who-can-message","description", etc. are also English, so this section appears entirely untranslated). Consider requesting an Uzbek translation for this section from Crowdin contributors.
3119-3119: Untranslated string in Uzbek locale.Same as above —
"Add new keys"remains in English rather than Uzbek. This is consistent with the pattern across other locales in this PR where the same English text is used. Low priority, but worth flagging for eventual translation.
| "settings": { | ||
| "dm-privacy": { | ||
| "title": "Chat Privacy", | ||
| "title": "Direct Message Privacy", |
There was a problem hiding this comment.
Both updated strings are in English, not translated to Hindi.
The values "Direct Message Privacy" (Line 1196) and "Add new keys" (Line 3119) remain in English in this Hindi (hi-IN) locale file. Per the AI summary, the same English text was applied identically across all 22 non-English locale files. If these are intentional source-string updates waiting for translators to localize via Crowdin, this is fine as a transient state. Otherwise, Hindi translations should be provided.
Also applies to: 3119-3119
🤖 Prompt for AI Agents
In `@apps/web/src/features/i18n/locales/hi-IN.json` at line 1196, The hi-IN locale
contains English text for the keys whose values are "Direct Message Privacy" and
"Add new keys"; update the hi-IN.json entries for these keys by replacing the
English strings with correct Hindi translations (e.g., translate "Direct Message
Privacy" and "Add new keys" into Hindi) or, if these are intentionally left as
source strings awaiting translators, add a clear TODO/comment and confirm this
is expected across all non-English locales; locate and update the specific JSON
keys matching those exact values to keep the locale consistent.
| "title": "Keys & Passwords", | ||
| "hint": "A Hive account can hold multiple keys simultaneously, all of which are listed below", | ||
| "add-key": "Add/Manage keys", | ||
| "add-key": "Add new keys", |
There was a problem hiding this comment.
Untranslated string: "Add new keys" remains in English for Lithuanian locale.
Same as above — this appears to be an untranslated English fallback. Consistent with the existing pattern of mixed English/Lithuanian in this file.
🤖 Prompt for AI Agents
In `@apps/web/src/features/i18n/locales/lt-LT.json` at line 3119, The "add-key"
translation in lt-LT.json is still in English; update the value for the
"add-key" key to the proper Lithuanian translation (e.g., "Pridėti naujus
raktus") so the Lithuanian locale contains a localized string for that key.
Summary by CodeRabbit