Skip to content

Replace DND package for Decks#736

Merged
feruzm merged 2 commits into
developfrom
dnd
Apr 3, 2026
Merged

Replace DND package for Decks#736
feruzm merged 2 commits into
developfrom
dnd

Conversation

@feruzm
Copy link
Copy Markdown
Member

@feruzm feruzm commented Apr 3, 2026

Summary by CodeRabbit

  • Chores
    • Switched to a maintained drag-and-drop library for more reliable DnD behavior.
    • Replaced client-side polyfills with a no-op substitute to reduce client bundle size.
    • Adjusted build configuration so client bundles no longer include redundant browser polyfills, improving load performance.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d8035e7f-b562-444e-8e1b-3a4a7ef736a2

📥 Commits

Reviewing files that changed from the base of the PR and between f2f41fa and a58e443.

📒 Files selected for processing (2)
  • apps/web/next.config.js
  • apps/web/src/empty-polyfill.js
✅ Files skipped from review due to trivial changes (1)
  • apps/web/src/empty-polyfill.js

📝 Walkthrough

Walkthrough

Expanded Next.js webpack hook to receive the webpack parameter and conditionally replace client-side Next.js polyfills with an empty module; migrated drag-and-drop imports and types from react-beautiful-dnd to @hello-pangea/dnd; added an empty polyfill placeholder file.

Changes

Cohort / File(s) Summary
Webpack & Polyfill Config
apps/web/next.config.js, apps/web/src/empty-polyfill.js
next.config.js webpack hook now accepts webpack and, when !isServer, registers webpack.NormalModuleReplacementPlugin to replace Next.js' polyfill-module.js with src/empty-polyfill.js. Added src/empty-polyfill.js (empty placeholder).
Dependency manifest
apps/web/package.json
Removed react-beautiful-dnd and its types; added @hello-pangea/dnd dependency.
Deck components — drag-and-drop types & imports
apps/web/src/app/decks/_components/columns/*, apps/web/src/app/decks/_components/.../generic-deck-column.tsx, apps/web/src/app/decks/_components/deck-grid.tsx, apps/web/src/app/decks/_components/header/deck-header.tsx
Replaced imports/types from react-beautiful-dnd with @hello-pangea/dnd across deck column components, generic column, grid, and header. Runtime logic and component APIs unchanged; only import sources/types updated.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested labels

patch

Poem

🐰 Hopped into configs, swapped an import or two,

Replaced old dances with a fresh debut.
Polyfills silenced in a tiny empty file,
Columns keep leaping with a newer style.
A joyful thump — project updated, all in a mile.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Replace DND package for Decks' accurately reflects the main change: replacing react-beautiful-dnd with @hello-pangea/dnd across the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dnd

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@apps/web/src/empty-polyfill.js`:
- Around line 1-2: Update the misleading browser baseline comment in
next.config.js: replace the current "Chrome 90+, Safari 15+, Firefox 90+, Edge
90+" claim with the accurate minimums for features used (Object.hasOwn and
Array.prototype.at) — e.g. "Chrome 93+, Firefox 92+, Safari 15.4+, Edge 93+" —
or alternatively confirm the project’s supported browsers list meets those
minimums before removing polyfills; reference next.config.js and the features
Object.hasOwn and Array.prototype.at when making the change.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 15983609-51f7-49ad-b8eb-89922c33092f

📥 Commits

Reviewing files that changed from the base of the PR and between 8e84b58 and f2f41fa.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (20)
  • apps/web/next.config.js
  • apps/web/package.json
  • apps/web/public/sw.js
  • apps/web/src/app/decks/_components/columns/add-column/deck-add-column.tsx
  • apps/web/src/app/decks/_components/columns/deck-community-column.tsx
  • apps/web/src/app/decks/_components/columns/deck-faq-column.tsx
  • apps/web/src/app/decks/_components/columns/deck-msf-column.tsx
  • apps/web/src/app/decks/_components/columns/deck-notifications-column.tsx
  • apps/web/src/app/decks/_components/columns/deck-search-column.tsx
  • apps/web/src/app/decks/_components/columns/deck-threads-column.tsx
  • apps/web/src/app/decks/_components/columns/deck-topics-column.tsx
  • apps/web/src/app/decks/_components/columns/deck-trending-column.tsx
  • apps/web/src/app/decks/_components/columns/deck-user-column.tsx
  • apps/web/src/app/decks/_components/columns/deck-wallet-balance-column.tsx
  • apps/web/src/app/decks/_components/columns/deck-wallet-column.tsx
  • apps/web/src/app/decks/_components/columns/deck-whats-new-column.tsx
  • apps/web/src/app/decks/_components/columns/generic-deck-column.tsx
  • apps/web/src/app/decks/_components/deck-grid.tsx
  • apps/web/src/app/decks/_components/header/deck-header.tsx
  • apps/web/src/empty-polyfill.js

Comment thread apps/web/src/empty-polyfill.js Outdated
@feruzm feruzm merged commit 62db7c4 into develop Apr 3, 2026
1 check passed
@feruzm feruzm deleted the dnd branch April 3, 2026 06:43
@coderabbitai coderabbitai Bot mentioned this pull request Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant