Skip to content

Internal access#738

Merged
feruzm merged 4 commits into
developfrom
vapi
Apr 4, 2026
Merged

Internal access#738
feruzm merged 4 commits into
developfrom
vapi

Conversation

@feruzm
Copy link
Copy Markdown
Member

@feruzm feruzm commented Apr 3, 2026

Summary by CodeRabbit

  • Chores

    • Added INTERNAL_API_HOST entries to environment template and compose files.
  • New Features

    • Added a new public API node endpoint.
  • Accessibility & Localization

    • Added ARIA labels for navigation and TTS settings.
    • Added localization keys: chat title, toggle menu, and text-to-speech settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 3, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e53883a0-0bd6-4cd4-8344-f9bef784cd0d

📥 Commits

Reviewing files that changed from the base of the PR and between 9d94ca0 and d12aa40.

📒 Files selected for processing (1)
  • apps/web/src/features/i18n/locales/en-US.json

📝 Walkthrough

Walkthrough

Adds INTERNAL_API_HOST (template and compose), updates SDK init to prefer an internal host for server-side SSR, adds a public node, and introduces accessibility aria-labels plus new i18n keys.

Changes

Cohort / File(s) Summary
Environment & Compose
apps/web/.env.template, apps/web/docker-compose.yml, apps/web/docker-compose.production.yml
Added INTERNAL_API_HOST example/comment to env template and set INTERNAL_API_HOST=http://vapi:4000 in both compose files.
SDK Init / SSR routing
apps/web/src/core/sdk-init.ts
Adjusted API host selection to detect server vs client; server-side (SSR) prefers process.env.INTERNAL_API_HOST for non-main-production, falling back to public URL; client behavior unchanged for main production.
Public nodes
apps/web/public/public-nodes.json
Inserted new public node: https://hapi.ecency.com.
Accessibility / Navbar
apps/web/src/features/shared/navbar/navbar-desktop.tsx, apps/web/src/features/shared/navbar/navbar-main-sidebar-toggle.tsx
Added aria-label attributes using i18next.t(...); imported i18next where required.
Text-to-speech UI
apps/web/src/app/.../entry-page-listen.tsx
Added localized aria-label for Text-to-Speech settings button.
i18n locales
apps/web/src/features/i18n/locales/en-US.json
Added translation keys: navbar.toggle-menu, g.tts-settings, and chat.title (repositioned).

Sequence Diagram(s)

sequenceDiagram
  actor Browser
  participant WebServer as "Web (SSR)\nrgba(66,135,245,0.5)"
  participant InternalAPI as "vapi (Internal API)\nrgba(75,181,67,0.5)"
  participant PublicAPI as "https://ecency.com\nrgba(245,130,48,0.5)"

  Browser->>WebServer: Request page (SSR)
  alt Server-side and INTERNAL_API_HOST set
    WebServer->>InternalAPI: Fetch data via INTERNAL_API_HOST
    InternalAPI-->>WebServer: Data
  else Server-side and no INTERNAL_API_HOST
    WebServer->>PublicAPI: Fetch data via public URL
    PublicAPI-->>WebServer: Data
  end
  WebServer-->>Browser: Rendered HTML
  Browser->>PublicAPI: Client-side API calls (relative or public host)
  PublicAPI-->>Browser: Client data
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • Internal access #738 — Contains the same edits across env template, compose files, SDK init, public nodes, i18n, and navbar/tts components (direct overlap).
  • Server fallbacks, image saving #677 — Overlaps SDK init and public-nodes.json changes (related initialization and node handling).

Suggested labels

patch

Poem

🐰
I nibble configs, hop through compose and code,
Guide SSR to vapi down the secret road,
Buttons now whisper labels crisp and neat,
A new node joins the public streets,
Hooray — the rabbit's changes skip a beat! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Internal access' is partially related to the changeset. While it refers to adding internal API host configuration for SSR calls and docker-compose setup, it is vague and doesn't capture the main changes clearly. The changeset involves multiple distinct improvements: internal API routing for SSR, accessibility enhancements (aria-labels), translation additions, and public node configuration. Consider a more specific title like 'Add internal API host for SSR and improve accessibility labels' to better communicate the primary changes to reviewers.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch vapi

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@apps/web/src/features/i18n/locales/en-US.json`:
- Line 2191: There is a duplicate JSON key "chat.title" in the en-US locale
file; remove the redundant entry so only a single "chat.title" remains (either
delete the earlier duplicate or merge any differing values into the canonical
one) to resolve the duplicate-key lint error and ensure the intended value is
reachable.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1544da58-b3a4-45ef-ade4-3440db760ae8

📥 Commits

Reviewing files that changed from the base of the PR and between 8fbbc4e and 9d94ca0.

📒 Files selected for processing (6)
  • apps/web/public/public-nodes.json
  • apps/web/public/sw.js
  • apps/web/src/app/(dynamicPages)/entry/[category]/[author]/[permlink]/_components/entry-page-listen.tsx
  • apps/web/src/features/i18n/locales/en-US.json
  • apps/web/src/features/shared/navbar/navbar-desktop.tsx
  • apps/web/src/features/shared/navbar/navbar-main-sidebar-toggle.tsx
✅ Files skipped from review due to trivial changes (2)
  • apps/web/src/app/(dynamicPages)/entry/[category]/[author]/[permlink]/_components/entry-page-listen.tsx
  • apps/web/public/public-nodes.json

Comment thread apps/web/src/features/i18n/locales/en-US.json
@feruzm feruzm merged commit 2729ffa into develop Apr 4, 2026
1 check was pending
@feruzm feruzm deleted the vapi branch April 4, 2026 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant