Update mattermost-channels spec for streaming fetchers#777
Conversation
After #776, fetchAllChannelPages calls /users/me/channels once (no pagination) and fetchAllChannelMemberPages calls /users/me/channel_members?page=-1 via mmUserFetchNdjson. The previous spec asserted multi-page pagination and imported the removed pageSize / maxPages constants, so all three test cases failed (NaN length assertions from the missing imports). Replace with tests that match the new behaviour: - /channels: one mmUserFetch call to /users/me/channels, returns the streamed array; non-array upstream responses return []. - /channel_members: one mmUserFetchNdjson call to /users/me/channel_members?page=-1, returns the parsed array. Verified locally: vitest run mattermost — 13/13 pass; full suite — 965/965 pass.
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
After #776, fetchAllChannelPages calls /users/me/channels once (no pagination) and fetchAllChannelMemberPages calls
/users/me/channel_members?page=-1 via mmUserFetchNdjson. The previous spec asserted multi-page pagination and imported the removed pageSize / maxPages constants, so all three test cases failed (NaN length assertions from the missing imports).
Replace with tests that match the new behaviour:
Verified locally: vitest run mattermost — 13/13 pass; full suite — 965/965 pass.