Closed
Conversation
…ctives will compile before children directives. This will fix the issue with children calling .emit not reaching the ngScrollable as it hadn't been compiled yet. Updated the readme.md, reversing and as goes UP along the DOM and goes DOWN, so children of ngScrollable should be calling rather than .
… in grunt build task.
Owner
|
I finally remembered your PR .. :/ and made a version less intrusive in the number of lines changed (due to indentation). Closing this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#16
The problem turned out to be that the ng-scrollable hadn't compiled before the children, so it wouldn't respond to any $scope.$emit's made by children nor would it properly examine the size of the DOM.
Moving the link function to preLink fixes this by having ng-scrollable compile BEFORE child elements.
Updated documentation, reversing $emit and $broadcast as $emit goes UP the DOM, $broadcast goes DOWN the DOM.