Skip to content

Conversation

@echo094
Copy link
Owner

@echo094 echo094 commented Nov 5, 2023

The string array is not wrapped in a function before 2.19.0. Hence, it's not suitable to identify the string array directly, and the fallback mode is made for this situation. However, the previous fallback mode cannot match the rotate function correctly in some cases (e.g. #50 ).

I have reworked this part based on the source code. The new method will traverse the CallExpression instead, which is the surface of the RotateFunction. After finding the RotateFunction, we can identify the StringArray and StringArrayCallsWrapper.

Besides, we have to identify three versions of StringArrayCallsWrapper:

@echo094 echo094 marked this pull request as ready for review November 5, 2023 07:31
Signed-off-by: echo094 <20028238+echo094@users.noreply.github.com>
@echo094 echo094 force-pushed the ob_string_array_v2 branch from f733076 to b48825f Compare November 5, 2023 07:35
@echo094 echo094 merged commit 9a673d8 into main Nov 5, 2023
@echo094 echo094 deleted the ob_string_array_v2 branch November 5, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants