Creates and uses shared Footer component#235
Merged
kgajera merged 1 commit intoechobind:canaryfrom Nov 5, 2021
Merged
Conversation
kyleshevlin
force-pushed
the
footer-changes
branch
from
c7a3825 to
772a792
Compare
philipj93
reviewed
Oct 19, 2021
code-jenn-or
approved these changes
Nov 4, 2021
Contributor
code-jenn-or
left a comment
code-jenn-or
left a comment
There was a problem hiding this comment.
Great to see this refactor, one component to rule them all
kyleshevlin
force-pushed
the
footer-changes
branch
from
772a792 to
36929ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed an issue with a static year in the footer of the layouts. This PR fixes this, and creates a shared Footer.
Changes
Footercomponentyearfor the copyrightitoem(though arguably this should be done with CSS as I don't think the content itself is semantically emphasized).Checklist